YamlDotNet icon indicating copy to clipboard operation
YamlDotNet copied to clipboard

For discussion purposes:

Open steinbitglis opened this issue 8 years ago • 3 comments
trafficstars

These are some of the changes for the Unity version of the library. ExampleRunner.cs has been added to enable running of the examples. 'ValidatingDuringDeserialization.cs' has been skipped since I didn't find out how to address the dependencies.

Consider if you want to include any of these changes. I'm maintaining a difference between the code bases for Unity users, for convenience, but of course I want to keep it as small as possible. In my package I don't want to require the 'UNITY' define flag either, so the package has a few additional changes compared to this.

steinbitglis avatar Jan 28 '17 16:01 steinbitglis

Thanks, I'll try to merge them as best as possible. Ideally, you should not need to maintain different code for unity. I'll look at this during this week-end.

aaubry avatar Feb 03 '17 11:02 aaubry

Removing the dependency from xunit is a problem for the samples, because I use xunit to execute them. I could use something different, but I already have stuff built on top of that.

It seems that Unity specifies a set of #defines. Maybe we could take advantage of that? For example, if the unity-specific tweaks are wrapped inside #ifdef UNITY_5, it should be easier to merge these changes in the main code. What do you think?

aaubry avatar Feb 06 '17 22:02 aaubry

I've merged the "easy" changes, that don't cause conflicts, to let us focus on the hard ones.

aaubry avatar Feb 06 '17 22:02 aaubry

This PR appears to be abandoned, it's nearly 5 years old. I'm going to close it.

EdwardCooke avatar Jan 13 '23 20:01 EdwardCooke