terraform-provider-dokku icon indicating copy to clipboard operation
terraform-provider-dokku copied to clipboard

Published 20 hours ago • verified publisher icon aaronstillwell

Escaped quotes in string Issue #7

Open jyoost opened this issue 3 years ago • 3 comments

I wanted to get this in. I will do a separate PR for the test before you merge.

jyoost avatar Mar 07 '22 20:03 jyoost

Thanks for your submission @jyoost! LGTM so far (sans acceptance test). This TODO can also be removed 😄

https://github.com/aaronstillwell/terraform-provider-dokku/blob/a7a4f0c465aa7afdfc4f427db33c4ce4266a6d6c/internal/provider/dokku.go#L96

aaronstillwell avatar Mar 07 '22 20:03 aaronstillwell

Note no reason for a separate PR - you should be able to just push the test as an additional commit.

aaronstillwell avatar Mar 07 '22 21:03 aaronstillwell

will do

On Mon, Mar 7, 2022 at 1:12 PM Aaron Stillwell @.***> wrote:

Note no reason for a separate PR - you should be able to just push the test as an additional commit.

— Reply to this email directly, view it on GitHub https://github.com/aaronstillwell/terraform-provider-dokku/pull/9#issuecomment-1061141045, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKU5P6M5UYW6WL5HHYYSH6LU6ZWLZANCNFSM5QELYPNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

jyoost avatar Mar 07 '22 21:03 jyoost