jekyll-webmention_io icon indicating copy to clipboard operation
jekyll-webmention_io copied to clipboard

Update webmention dependency from 0.1.6 to latest (v5.0.0)

Open 0xdevalias opened this issue 5 years ago • 8 comments

Currently this plugin depends on an old version of the webmention gem (0.1.6), which is now up to 3.0.0.

  • https://github.com/aarongustafson/jekyll-webmention_io/blob/master/jekyll-webmention_io.gemspec#L47
    • s.add_runtime_dependency "webmention", "~> 0.1.6"
  • https://github.com/indieweb/webmention-client-ruby/releases
    • breaking changes at v1.0

0xdevalias avatar Jul 21 '20 01:07 0xdevalias

Now the webmention ruby gem is at 4.0 https://github.com/indieweb/webmention-client-ruby/releases

cgorshing avatar Sep 15 '20 02:09 cgorshing

I kept having Ruby/Jekyll issues when upgrading my Mac, so I have moved off of Jekyll and will not be working on this project anymore, going forward. I am going to flag this as won’t fix, but leave it open in case someone else wants to pick up the project from here.

aarongustafson avatar Jul 22 '21 21:07 aarongustafson

I'd be interested in helping with this as I'm currently using it.

cgorshing avatar Jul 22 '21 21:07 cgorshing

@cgorshing Do you already have a draft of the necessary changes available that you could use to open a PR? I've been added as a contributor on the project and can work with you to merge them in.

fancypantalons avatar Nov 11 '21 23:11 fancypantalons

I've created a PR for this but I haven't had a chance to throughly test it yet. The changes are small enough that I think it's in good shape, but if anyone could give this PR a shot, that'd be very helpful!

fancypantalons avatar Nov 12 '21 23:11 fancypantalons

Well, irony of ironies, the Webmention client moved to explicitly not allowing Ruby 3 back in June of 2018, which means that if I upgrade the Webmention dependency, we lose the ability to run on Ruby 3. For now I'm going to hold this PR and hopefully the Webmention gem will get updated...

fancypantalons avatar Nov 13 '21 22:11 fancypantalons

@fancypantalons -> https://github.com/indieweb/webmention-client-ruby/commit/a31aae69b176a681d965976a44b9c900847c1c42 😄

cgorshing avatar Jan 10 '22 03:01 cgorshing

It doesn't look like they've published a new version of the gem, but this is good progress! Just gotta wait, now...

fancypantalons avatar Jan 23 '22 00:01 fancypantalons

It's been some year... alright... finally getting back to this.

I've pushed this change to main. I've done some basic smoke testing but it deserves some more validation before I close the issue.

fancypantalons avatar Nov 28 '22 02:11 fancypantalons

Pushed 3.3.7 which upgrades the dependency to 7.0.0.

fancypantalons avatar Feb 19 '23 20:02 fancypantalons