Aaron Dill

Results 129 comments of Aaron Dill

@f-person I have this same problem. The fix is a one line change. I'm willing to submit a pull request if that'd get this fixed sooner!

I have no idea why the checks are failing to compile. This compiles (and runs successfully) locally. All the "missing" symbols should be provided by ``.

It turns out the GLIB Version is too low. [The source](https://github.com/GNOME/glib/blob/main/glib/gspawn.h#L191-L216) specifies that it's only available from version >=2.74; but this is not shown in the [docs](https://docs.gtk.org/glib/flags.SpawnFlags.html#stdin_from_dev_null). The `gir1.2-gtk-3.0` Ubuntu...

@actionless I added a (compile-time) version check. I tried to use ifdef, but for some reason it wouldn't detect as defined.

The new behavior has been added to the documentation

Is there anything left for me to do for this to be merged, or are we just waiting for another review?

@Aire-One If I understand correctly, that check is testing *each* commit to check that they all pass tests? Should I squash the commits together to ensure that the (now one)...

Alright, I've all the commits into the first (primary) commit.

From what I can tell, the CI checks failed during setup (and thusly not due to my code)

I currently haven't touched `awful.spawn`, are you saying you'd like me to add this functionality there (as well)? I currently _do_ have the >2.74 functionality behind an `#if GLIB_CHECK_VERSION(2,74,0)`, which...