Aaron Craelius

Results 312 comments of Aaron Craelius

@paul121 I updated `UpdateProjectEnrollment` to allow transitions from `UNSPECIFIED` or `CHANGES_REQUESTED` to `UNSPECIFIED` with updates to metadata in https://github.com/regen-network/regen-ledger/pull/2167/commits/fd96f717e8fa1574b9fe8a941b8a6fc82c752434. Please review that commit and let me know what you think.

> Ryan and I reviewed this PR today during the regen ledger office hours he is hosting and came out with an important question regarding this feature: Why is the...

> The fact that fees could change after the sell order is created was our main concern. Perhaps it isn't a huge issue, but just wanted to make sure to...

@paul121 @JeancarloBarrios I believe I have addressed all concerns. I have also added a new message `MsgGovSendFromFeePool` so that governance can actually manage the fee pool. This was initially missing....

Thanks @glandua. I think the key high-level points to keep in mind here is that: * buyers could be charged a percentage fee on marketplace transactions on top of what...

> > I have also added a new message MsgGovSendFromFeePool so that governance can actually manage the fee pool. This was initially missing. Please take another look when you get...

Thanks for the reviews @JeancarloBarrios and @paul121. Going to go ahead and merge this now.

Looks like @tac0turtle took care of linting and I'm seeing an unrelated test failure for x/accounts, but maybe that's fixed on main. Is this ready to merge?

Vini? Sorry I noticed there's a lint error just haven't gotten a chance to fix yet

Thanks @EmilGeorgiev. What would be helpful is if you could write out what the encoding format is now (this should be documented anyway) and also how that differs from what...