Aaron Prindle

Results 163 comments of Aaron Prindle

The kokoro issue here is related to our kokoro pipeline recently upgrading the version of bazel that it uses and the files in runtimes-common not being compatible with this new...

@belchatek friendly ping. The CI issues you were experiencing are resolved now, resubmit and kokoro should have sane logs for the FTL tests

Can you describe the environment/builder-image you are using? In attempting the same requirements.txt I am seeing: ``` Step #2 - "build-image-gcr.io/ftl-node-test/repro_test-image:latest": INFO Pushing image to Docker registry took 4 seconds...

running with w/python3.6 ``` Step #2 - "build-image-gcr.io/ftl-node-test/repro_test-image:latest": INFO Pushing image to Docker registry took 2 seconds Step #2 - "build-image-gcr.io/ftl-node-test/repro_test-image:latest": INFO Uploading final image took 2 seconds Step #2...

@myelin thanks for reporting this, the build times definitely rose per package when we updated to uploading each packages for phase 1.5 python. #607 should fix this by uploading the...

> can the download wheels be done in parallel? this is the overarching problem of: phase 1 vs phase 2 requirements.txt. vs Pipfile you can't download the wheels in parallel...

it seems that it isn't possible as for common shared libs, a parallel download would introduce a race possible race condition on the package used: https://github.com/pypa/pip/issues/825#issuecomment-301968349

it might actually be alright: https://github.com/pypa/pip/issues/825#issuecomment-302020952 https://github.com/pypa/pip/issues/825#issuecomment-319148864 I'm going to to a POC and investigate further

with POC: https://github.com/GoogleCloudPlatform/runtimes-common/pull/614 Test requirements.txt https://gist.github.com/aaron-prindle/758f9ef4141669e19907b17da40f657d Timing: https://gist.github.com/aaron-prindle/0764d32a928cc5002f6a6eb46c4c36f0 important pieces: pip_download_wheels took 68 seconds the timing is the same w/ or w/o the parallel so I believe that pip wheel...

@rahulrv1980 yes, it seems that downloading the wheels for the google client libraries alone takes ~1 minute