Aaron Pham

Results 459 comments of Aaron Pham
trafficstars

Will ping once it is ready, discussing with Yixin atm to clear up some confusion

@WoosukKwon the initial implementation should be ready for first round of eyes now. also cc @russellb whenever you have a chance, and @mgoin if you are interested

cc @mmoskal probably also want your input on this as well.

> I'm not sure the added complexity is worth it, IDEs can follow the strings anyway: > > ![image](https://private-user-images.githubusercontent.com/19981378/439239962-50efe469-4e70-440e-9ec1-58658aa89e9c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDYwMjM0OTAsIm5iZiI6MTc0NjAyMzE5MCwicGF0aCI6Ii8xOTk4MTM3OC80MzkyMzk5NjItNTBlZmU0NjktNGU3MC00NDBlLTllYzEtNTg2NThhYTg5ZTljLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA0MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNDMwVDE0MjYzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRlODc1OTRjZjY2MGY0NDI5ZjI3MDNkMTY3NmE5OWZlMDczZjVkZTQ5MDAzNTVhNzNhMTAwYjgyNmI2Nzc4OWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.6Mn3ekZGsLJtbnnCR5hlkP6yHTYpsugLXUZ3m4fDT5U) Yeah, let's just close this PR then?

> * The proposed tokens need to be checked for validity according to the matcher. For each draft token, it should either be restricted to be sampled from the guided...

Oh this is added in 3.13. I will take a look for backport on this then

Hmm, then maybe similar implementation as the builtins behaviour of 3.13 would suffice?

@hmellor should be ready for another round of review

example https://github.com/yuchanns/avante_bedrock.nvim We will need to cosnider how to support different model with providers such as bedrock. for example you can run mistral, claude, command-r, and even jamba on there.