Ahmad Fatoum

Results 60 comments of Ahmad Fatoum
trafficstars

Thanks, @Bastian-Krause! Changes look ok to me.

Personally, I lack the time and drive to support the new client versions. But hey, this is open source and I am happy to review any pull requests1 that improve...

I can't reproduce this locally with either current master (https://github.com/wireshark/wireshark/commit/9ac8dcb3a124eb42c57d4c0aa8d626ff1fefbb4e) or v3.2.8 (https://github.com/wireshark/wireshark/commit/8c208b7f257de50613e1e6a09a5b221f284883a0). Could you describe the steps to reproduce? I tested with [1077.pcap.gz](https://github.com/a3f/tibia-pcaps/blob/master/1077.pcapng.gz) and [OTServ privat key](https://metacpan.org/source/ATHREEF/Game-Tibia-Packet-0.007/share/otserv.private): ``` "192.236.132.181","7171","/home/a3f/prjs/Game-Tibia-Chess/share/otserv.private",""...

I think I vendored HIDAPI to make Windows builds easier, but I don't think it's a good idea anymore. We could fix the warning, but I think the best thing...

It hangs inside HIDAPI, which is doubly strange, because we specify a 2 second timeout, so it should've just failed if nothing happens.. As for the actual issue, sorry, no...

Sorry, I missed this issue. It used to work when I implemented it, might be that newer firmwares behave differently. I can't debug this, but if someone can and submits...

Great! Do you package them manually or is there some CI/CD that does that? I couldn't see any references to `ev3duder` in https://github.com/ev3dev/ev3dev-tools.

Is this meant as a recommendation to mask ROM authors?

> Currently U-Boot SPL loads main U-Boot by partition number (CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION), MBR partition type (CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION_TYPE), or sector (CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR, CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_DATA_PART_OFFSET). The limits on U-Boot SPL may be so tight that a...