graphein
graphein copied to clipboard
hotfix greater than/less than operations in pdb_manager
Reference Issues/PRs
What does this implement/fix? Explain your changes
Greater than / less than comparisons in oligomer selection in PDBManager are switched to greater than or less than.
What testing did you do to verify the changes in this PR?
Pull Request Checklist
- [ ] Added a note about the modification or contribution to the
./CHANGELOG.mdfile (if applicable) - [ ] Added appropriate unit test functions in the
./graphein/tests/*directories (if applicable) - [ ] Modify documentation in the corresponding Jupyter Notebook under
./notebooks/(if applicable) - [ ] Ran
python -m py.test tests/and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,python -m py.test tests/protein/test_graphs.py) - [ ] Checked for style issues by running
black .andisort .
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
Project coverage is 45.23%. Comparing base (
8123f42) to head (c780734). Report is 184 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| graphein/ml/datasets/pdb_data.py | 0.00% | 8 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #408 +/- ##
==========================================
+ Coverage 40.27% 45.23% +4.96%
==========================================
Files 48 113 +65
Lines 2811 8188 +5377
==========================================
+ Hits 1132 3704 +2572
- Misses 1679 4484 +2805
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code