perfume.js icon indicating copy to clipboard operation
perfume.js copied to clipboard

Cannot read properties of undefined (reading 'requestStart') on navigation with bfcache

Open meskill opened this issue 2 years ago • 2 comments

I'm getting the error from the title on this line when testing bfcache in chrome browser.

Reproduction

  1. Open Chrome DevTools -> Application -> Back/Forward Cache
  2. Click Test Back/Forward cache

image

meskill avatar Feb 03 '23 08:02 meskill

Initial problem from web-vitals package - https://github.com/GoogleChrome/web-vitals/issues/313

SuperOleg39 avatar Feb 03 '23 09:02 SuperOleg39

Following the discussion in web-vitals repo, we can still report 0 values and add just fix for BFCache case - https://github.com/Zizzamia/perfume.js/pull/221

SuperOleg39 avatar Feb 03 '23 10:02 SuperOleg39

i believe we are hitting this error as well fwiw

undefined is not an object (evaluating 'e.entries[0].requestStart')

scamden avatar Mar 22 '24 19:03 scamden

@scamden what version are you using?

Zizzamia avatar Mar 23 '24 07:03 Zizzamia

8.4.0, should i try an upgrade?

scamden avatar Mar 25 '24 18:03 scamden

I'm upgrading to 9.4 and will let you know if we see again

scamden avatar Mar 26 '24 04:03 scamden

Also, curios, what version of web-vitals are you resolving, maybe we need to upgrade from Perfume side as well.

Zizzamia avatar Mar 26 '24 08:03 Zizzamia

Also, curios, what version of web-vitals are you resolving, maybe we need to upgrade from Perfume side as well.

@Zizzamia we have 3.5.2 for web vitals

scamden avatar Mar 26 '24 16:03 scamden

prior to the upgrade 3.4.0 fwiw

scamden avatar Mar 26 '24 16:03 scamden

@scamden do you still see the issue after upgrade?

Zizzamia avatar Apr 11 '24 14:04 Zizzamia

Haven't seen it since to my knowledge (although we had only seen it once so sample size is pretty low for this data :P )

Thanks for the tip on upgrading! Perfume is a great package :)

scamden avatar Apr 11 '24 16:04 scamden

Ok, so I think it's safe to close this for now.

I will reopen this if this issue happens again.

Zizzamia avatar Apr 12 '24 23:04 Zizzamia