Fixed, CXXGraph::Node::getData() should not be const #438

[yapa-ymtl]

Hi @ZigRazor This PR related to "CXXGraph::Node::getData() should not be const" issue with #438.

[ZigRazor]

the code does not compile... please check it

[yapa-ymtl]

Thanks , I am checking that

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.87%. Comparing base (564a8c0) to head (4bfa986).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files          87       87           
  Lines       10079    10081    +2     
  Branches      670      670           
=======================================
+ Hits         9865     9867    +2     
  Misses        214      214           

Flag	Coverage Δ
unittests	97.87% <100.00%> (+<0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[ZigRazor]

The workflow of build and test does not work in any platform( only windows fails in general ), but for ubuntu and macos the workflow should compile and test the library. Please check the problem and fix it. Thank you

[nolankramer]

@ZigRazor It seems the tests are failing for reasons unrelated to the code.

[JustCallMeRay]

@nolankramer they fail on Windows currently because CMake doesn't like the backwards slashes (\) instead of unix style slashes. I will try and get a PR to fix this out soon, probably changing to ./build instead of the absolute path. If Yapa merges in master it should work now.

@yapa-ymtl If you go to your repo and click actions then the big green button (enable?) you will be able to run the tests and compile it on a CI pipeline before launching a PR so you'll run into less comments like:

the code does not compile... please check it

Also run clang format to fix the formatting issues, it will give you feedback much more quickly!