accounts-material-ui icon indicating copy to clipboard operation
accounts-material-ui copied to clipboard

Published 20 hours ago • verified publisher icon Zetoff

Material 1.0.x support

Open yanickrochon opened this issue 8 years ago • 5 comments

At some point, Material v1.0.x will have to be supported because the project is already at the pre-release stage at this time.

I don't see a lot of breaking changes, apart from the obvious color API changes.

yanickrochon avatar Sep 18 '17 21:09 yanickrochon

I have attempted rewriting the component, and it's a little more than fixing imports. I would also replace FontAwesome with actual React components, notably icons from mdi-material-ui

yanickrochon avatar Oct 23 '17 02:10 yanickrochon

First commit, here for testing. I did remove unnecessary dependencies (probable fix for #34?) Did not implement the PR #33.

Comments welcome, and hopefully a PR whenever possible.

yanickrochon avatar Oct 23 '17 04:10 yanickrochon

I agree we need to move to Material-UI 1.0.x. I'll try to get some work done on this in the coming weeks as I need it for a project.

I'll have a look at PR #33.

PolGuixe avatar Oct 23 '17 08:10 PolGuixe

Great! I just started a project and need it as well. As I upgraded my branch to 1.x of MUI, there is now a Grid component that should be part of the default layout, and I wil make another commit, tonight about this. Comments welcome! If all is alright with you, this branch can then be merged into a next branch in this repository and continue to work from there. I'm more than happy to contribute.

yanickrochon avatar Oct 23 '17 11:10 yanickrochon

What's the status of this?

yanickrochon avatar Jan 19 '18 19:01 yanickrochon