zebra
zebra copied to clipboard
fix(qa): Fix tests and minor cleanups after `addnode` was added
Motivation
After #9604 was merged, some cleanup was required. Additionally, a few minor bugs were discovered that needed to be fixed.
Solution
- Reverted a mistaken use of a unified address in the test config, restoring a valid Regtest transparent address (https://github.com/ZcashFoundation/zebra/commit/81893431120b98fcb5a6471428ba19735296ded9).
- Increased the Zebra startup timeout to reduce test flakiness (https://github.com/ZcashFoundation/zebra/commit/468426f130e3248f5305283834e4edbb33922dab).
- Cleaned up wallet tests by removing outdated TODOs after the addnode RPC was merged (https://github.com/ZcashFoundation/zebra/commit/e5043bac964657dc0626478a0e55c1ae470eddfa).
Tests
All tests in the framework pass locally.
PR Checklist
- [ ] The PR name is suitable for the release notes.
- [x] The solution is tested.
- [ ] The documentation is up to date.
@Mergifyio update
update
✅ Branch has been successfully updated
This seems to be stuck in CI in the same way that contributor PRs are getting stuck, which is weird. I'll just admin-merge it for now