fix(network): send height to peers

[oxarbitrage]

Motivation

Zebra currently send height 0 in the start_height field of the Message::Version. This works protocol wise but DNS seeders expect a height here to classify peers. Resolves https://github.com/ZcashFoundation/zebra/issues/4875

Solution

Pretty simple solution, we already have everything available to end the height when we are building the version message.

Review

Anyone can review, i could be missing something as i thought this were going to be more complex. Local tests pass and i know this works while checkpointing, however i need to check a full sync. I expect the CI will assist me there.

Reviewer Checklist

• [ ] CI pass including full sync tests

[codecov[bot]]

Codecov Report

Merging #4904 (9ec3c07) into main (4cda4ee) will decrease coverage by 0.15%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #4904      +/-   ##
==========================================
- Coverage   79.18%   79.03%   -0.16%     
==========================================
  Files         309      309              
  Lines       38783    38786       +3     
==========================================
- Hits        30710    30654      -56     
- Misses       8073     8132      +59     

[teor2345]

You could try:

• increasing the timeouts on the failing tests
• updating the Zebra mainnet checkpoints (until #4721 gets merged, the full verifier will do twice as much note commitment work as the checkpoint verifier)

[oxarbitrage]

@mergifyio update

[mergify[bot]]

update

✅ Branch has been successfully updated

[teor2345]

It seems like Zebra appears in block explorers and nodes without this fix, so I'm reducing the priority to make room for other PRs in the queue.

[oxarbitrage]

@mergifyio update

[mergify[bot]]

update

✅ Branch has been successfully updated

[gustavovalverde]

@Mergifyio update

[mergify[bot]]

update

✅ Branch has been successfully updated