osm-revert icon indicating copy to clipboard operation
osm-revert copied to clipboard

Published 20 hours ago • verified publisher icon Zaczero

RATE_LIMITED on "Discussing changesets"

Open yrtimiD opened this issue 1 year ago • 5 comments

After reverting around 50 changesets within a few minutes with "Auto-discussion" enabled, some discussion comment adding fails with RATE_LIMITED.

yrtimiD avatar Jun 25 '24 22:06 yrtimiD

Hey! How would you want such situations to be handled? Currently it just skips over the failed discussions.

Zaczero avatar Jun 28 '24 18:06 Zaczero

Right, challenging situation. First thing I thought about is at least allowing manual retry action. User might need to wait some time before using the retry option. Also, if api response has a clue about lockout period - will be very nice to show it.

yrtimiD avatar Jun 28 '24 18:06 yrtimiD

With how osm-revert is designed, a manual retry action is not trivial to do. Ideally, osm-revert would parse OSM response headers to understand current rate limits and adjust its operation. However, I couldn't find any public documentation on this. The good news is that OpenStreetMap-NG already supports rate limit headers, so at some point, this issue will be resolved.

Zaczero avatar Jun 28 '24 19:06 Zaczero

I see. Maybe at least we can linkify changets numbers in the log to make manual discussion adding slightly less painful?

yrtimiD avatar Jun 28 '24 19:06 yrtimiD

Okay sounds really useful! I have created an issue but I cannot give any ETA on the completion date.

Zaczero avatar Jun 28 '24 19:06 Zaczero