osm-relatify icon indicating copy to clipboard operation
osm-relatify copied to clipboard

Duplicated roundabout

Open Dimitar5555 opened this issue 2 years ago • 10 comments
trafficstars

I'm not sure how or why it might've happened, but the roundabout is somehow duplicated. On the west side it is quite segmented.

image

All other segments are duplicated normally (from one exit/entrance to the next).

image

The duplicate was introduced in https://www.osm.org/changeset/139108622 and I've removed it manually in https://www.osm.org/changeset/139125857.

Dimitar5555 avatar Jul 28 '23 09:07 Dimitar5555

This occurred because two edits were performed in very quick succession, which didn't allow Overpass a chance to synchronize. I believe this issue could be resolved by temporarily storing recent splits in memory and preventing the user from loading a new relation when the database hasn't been fully synchronized. Alternatively, an even more advanced merge logic could be implemented to detect and resolve situations like this.

https://www.openstreetmap.org/changeset/139108512 https://www.openstreetmap.org/changeset/139108622

Thank you for reporting the bug!

Zaczero avatar Aug 19 '23 10:08 Zaczero

Through the following MapRoulette challenge, I came across a lot of these errors, mostly by myself and created by Relatify. https://maproulette.org/browse/challenges/39506

Here the initial changeset: https://www.openstreetmap.org/changeset/139253149 Here the fixing changeset: https://www.openstreetmap.org/changeset/141252802

mcliquid avatar Sep 14 '23 11:09 mcliquid

I have seen several instances of this bug in my neighbourhood recently, introduced by another contributor using osm-relatify.

The problem can be described like this:

  • the roundabout is split into very small ways, sometimes 2-nodes ways even when there is no intersecting road. This is weird and annoying for other contributors, but not really harmful
  • the ways of the roundabout are duplicated, with ways sitting on top of each other. Super confusing.
  • the public transport relations are messed up, because they take the roundabout twice!

This is creating a mess in OSM and requires time to clean up, can you at least workaround the problem so that people don't trigger this bug? Like forcing a delay between edits?

Here is an example of duplicated ways exhibiting the issues that I haven't yet fixed:

  • https://www.openstreetmap.org/way/1184234820
  • https://www.openstreetmap.org/way/1184234236

zorun avatar Sep 17 '23 19:09 zorun

This still happens on a lot of places. Is there any workaround to stop this happening? Hard reload the browser? How much time should I wait between edits?

infeeeee avatar Sep 25 '23 09:09 infeeeee

How much time should I wait between edits?

upload -> 3 minutes -> load

Zaczero avatar Sep 25 '23 12:09 Zaczero

This issue will be resolved with OpenStreetMap-NG project.

Zaczero avatar Dec 04 '23 15:12 Zaczero

Maybe it would be possible to turn on a timer (e.g. in the form of a stopwatch) between edits in realtify and block the download of the relation for a user who has just sent one edit?

Sometimes I forget about the 3-minute rule and this creates unwanted duplicates.

mutipg avatar Jul 08 '24 07:07 mutipg

I have added a conflict detection mechanism.

The issue should be now resolved :+1:. Sorry for keeping you waiting.

The message will look like: Conflict: Way XXXXX was modified. Go back and click the relation reload button.

Zaczero avatar Jul 09 '24 15:07 Zaczero

The problem still persists. Yesterday, two editions of a similar bus route with an interval of 3 minutes generated duplicate sections of the way.

  • 1st way created at 2024-10-03 21:36 https://pewu.github.io/osm-history/#/way/1320456812
  • 2nd way created at 2024-10-03 21:39 https://pewu.github.io/osm-history/#/way/1320457384 (I deleted this one as duplicate already)

mutipg avatar Oct 04 '24 18:10 mutipg

I will take a closer look at it, thanks for letting me know and sorry for the issue!

Additional info:

  • This is the main way: https://www.openstreetmap.org/way/202789937/history v14, v15

Zaczero avatar Oct 04 '24 21:10 Zaczero