react-flagpack icon indicating copy to clipboard operation
react-flagpack copied to clipboard

Broken release 1.1.0

Open lewis-fidlers opened this issue 4 years ago • 4 comments

Please check all that apply

  • [ ] visual bug
  • [ ] functional bug
  • [x] able to consistently reproduce

Current Behavior

When Installed through npm install react-flagpack --save

  • In a clean create react app (v17) empty flags are shown
  • In a react 16.8 or higher existing app using a flag components crashes the app (quite a big app with webpack which i think actually causes the crash)
  • in a clean create-react-app with react v16.x a blank flag is shown as well (step 4 in steps to reproduce)

Possible Solution

Seems like 1.1.0 was released yesterday, which is not tagged as the current release. It is installed through npm though when no version is specified.

So the easy fix is probably not making the 1.x branches available for now :)

Steps to Reproduce

  1. npx create-react-app my-app
  2. npm i react-flagpack
  3. add jsx <Flag code="NL" gradient="real-linear" size="m" hasDropShadow /> to the clean app
  4. a empty flag is shown: image

lewis-fidlers avatar Jul 29 '21 13:07 lewis-fidlers

same problem

mrzlab630 avatar Aug 12 '21 19:08 mrzlab630

same here as well

andrepadeti avatar Aug 17 '21 11:08 andrepadeti

Thanks for noting this issue. I've been working on a fix for this but this required some drastic changes. See #42 for more details. Also, if you have any thoughts regarding this let us know, possibly here or on our discussion regarding tree-shaking.

daoneandonly avatar Aug 26 '21 10:08 daoneandonly

While we still have some issues with react-flagpack, I've tested the latest build with an create-react-app and it rendered a Flag correctly. Can you confirm this issue has been solved?

daoneandonly avatar Sep 15 '21 14:09 daoneandonly