stylelint-a11y
stylelint-a11y copied to clipboard
YozhikM
Upgrade stylelint to 14.0.0
hey @igorkamyshev @YozhikM Any news on this PR?
Hey. Unfortunately, I have no permissions to merge PRs in this repo.
It looks like this plugin could use additional maintenance love – do the people currently involved with it take applications for new maintainers? I’d happily volunteer some of my time, accessibility-oriented rules feel invaluable for the whole stylelint ecosystem.
Apart from this peerDeps compatibility change, the project should also migrate from Travis to GitHub Actions like other stylelint projects have.
Yes! I just tried to install this, and found it's not compatible with stylelint 14. This is sorely needed. Thank you!
~~Sorry, I am very busy, maybe someone wants to send a PR?~~ That is PR :smile:
Can we add github actions (i.e. CI) here to run tests, because it is hard what it works fine with new version without problems?
It appears that @YozhikM is the only one with access to do that sort of thing. And he hasn't been active in a couple of years? I'm going to work on a fork to bring things up to date, unless or until this one can be maintained.
@alexander-akait implementation of a CI-workflow shouldn't be part of this PR imho. Separate topic, separate PR.
Sorry, I can't merge it without test, I understand what it should be part of another commit (but I don't understand why do not include it here), but I can't merge it without verification, it can be broken
I'm not sure how to add to a fork PR like this. But this should work if it's created at .github/workflows/test.yml
on:
pull_request:
branches: ['master']
jobs:
test:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Install Node.js
uses: actions/setup-node@v2
with:
node-version: 16.13
- name: Install
run: npm ci
- run: npm run test
Then, ideally, you'd update the settings for this repo to protect the master branch and require tests to pass before merging. Something like this: (but with the master branch, instead of main in the screenshot)
as we cant add to this pr, here is a separate one: https://github.com/YozhikM/stylelint-a11y/pull/67
Additionally: The tests are clean for stylelint 14, but the (dev-)deps are vastly outdated and full security-issues and would need a serious overhault. This, in turn, would need a decision about the build-infrastructure and clean handling of cjs/esm as it is mixed atm and fails for upgraded deps.
@alexander-akait Any chances on getting #67 merged so we can get movement on this?
For people following this discussion – there’s now talks of either adding some of those rules to Stylelint itself or creating another community plugin similar to stylelint-a11y here: https://github.com/stylelint/stylelint/issues/6212.
