extension icon indicating copy to clipboard operation
extension copied to clipboard

Feature -double click to like shorts

Open TheRGuy9201 opened this issue 5 months ago • 6 comments

Add Double-Click to Like Shorts Feature

Description

This PR adds a new feature that allows users to double-click anywhere on a YouTube Shorts video to "Like" it, similar to how double-tapping works on mobile apps like TikTok and Instagram.

Features

  • Double-clicking anywhere on a Shorts video triggers the like button
  • Shows a heart animation at the click point for visual feedback
  • Only likes videos that aren't already liked
  • Works seamlessly across YouTube Shorts navigation
  • Added to the extension settings under Miscellaneous section

Implementation Details

  • Uses event delegation to capture double-clicks on the Shorts player
  • Calculates time between clicks to detect double-clicks (300ms threshold)
  • Uses a MutationObserver to handle Shorts content changes
  • Adds visual feedback with an animated heart at the click location

Testing

  • Verified working on YouTube Shorts with various videos
  • Confirmed that double-clicking doesn't interfere with other YouTube controls
  • Tested with both liked and unliked videos to verify correct behavior

Summary by CodeRabbit

  • New Features
    • Added localization support for a new feature: "Double-click to like Shorts" across multiple languages. This feature description and label are now available in the app's interface and settings in all supported locales.

TheRGuy9201 avatar Jun 20 '25 14:06 TheRGuy9201

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Localization files for multiple languages were updated to add new entries describing the "Double-click to like Shorts" feature. This includes a label and title for the feature, primarily under the pages.content.features section, and in some locales, also under settings.sections.miscellaneous.features. No existing translations were modified or removed.

Changes

Files Change Summary
public/locales/ca-ES.json, .../de-DE.json, .../es-ES.json, .../ja-JP.json, .../ko-KR.json,
.../pl-PL.json, .../ru-RU.json, .../sv-SE.json Added doubleClickToLikeShorts label and title under pages.content.features.
public/locales/cs-CZ.json, .../en-GB.json, .../en-US.json, .../fa-IR.json, .../fr-FR.json,
.../he-IL.json, .../hi-IN.json, .../it-IT.json, .../pt-BR.json Added doubleClickToLikeShorts label and title under both pages.content.features and
settings.sections.miscellaneous.features.
public/locales/* (various) Reformatted indentation and whitespace for consistency (no change to translation content).

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant Localization
    User->>UI: Views features/settings
    UI->>Localization: Request label/title for "doubleClickToLikeShorts"
    Localization-->>UI: Returns localized label and title
    UI-->>User: Displays "Double-click to like Shorts" feature in selected language

Possibly related issues

  • YouTube-Enhancer/extension#836: Adds localization entries for the "doubleClickToLikeShorts" feature, directly matching the feature request in this issue.

Poem

In every tongue, a feature new,
Double-click to like—now global too!
From Hindi to French, and Swedish delight,
Shorts get a heart with a double-click light.
The rabbit hops with joy and glee,
For worldwide likes, as easy as can be!
🐇💖


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 20 '25 14:06 coderabbitai[bot]

@TheRGuy9201 there are a bunch of merge conflicts this shouldn't be the case. I don't think the branch was up to date. Also the PR should be made to the dev branch. I think the original branch wasn't based on the dev branch that might be where the issues come from.

VampireChicken12 avatar Jun 20 '25 19:06 VampireChicken12

@TheRGuy9201 The code itself looks pretty solid. The only issue is that the feature branch was based on the main branch. Can you make a new branch based off the dev branch, add your changes, and open a new pull request after requesting to merge to dev?

VampireChicken12 avatar Jun 20 '25 23:06 VampireChicken12

The code works but in my testing the short that is playing pauses when double clicking to like

VampireChicken12 avatar Jun 21 '25 05:06 VampireChicken12

Yeah, it can get paused as we are double-clicking. So, should I only focus on making a new branch and open a pull request, or should I also check into the matter of that play and pause

TheRGuy9201 avatar Jun 21 '25 07:06 TheRGuy9201

Make a new branch based on the dev branch and fix what I commented about. I already fixed the linting, and I pushed those changes to the current branch. When you are done with that, look into the play and pause issue.

https://github.com/YouTube-Enhancer/extension/pull/854#discussion_r2159864578

VampireChicken12 avatar Jun 21 '25 07:06 VampireChicken12