extension icon indicating copy to clipboard operation
extension copied to clipboard

[Bug Report] Can't play paused video in picture in picture mode if Pause Background Players is enabled

Open slrgt opened this issue 1 year ago • 22 comments

Describe the bug after pausing video in picture in picture mode if Pause Background Players is enabled its impossible to resume watching the video without going to the tab it is launched from

To Reproduce Steps to reproduce the behavior:

  1. Enable Pause Background Players
  2. open your video in Picture in Picture mode
  3. Switch tab
  4. try to play the video after pausing

Expected behavior The video in PiP mode should be able to be resumed without going in to the youtube tab it is from

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

slrgt avatar Apr 28 '24 18:04 slrgt

the videos also pause when opening a youtube channel even without a video autoplaying

slrgt avatar May 02 '24 15:05 slrgt

@slrgt thank you for the issue. We will look into the issue. It should be fixed in the next release

VampireChicken12 avatar May 02 '24 19:05 VampireChicken12

Thanks! It also seems that any youtube page load causes the video to pause instead of only pausing when a video starts to play

slrgt avatar May 08 '24 00:05 slrgt

Thanks! It also seems that any youtube page load causes the video to pause instead of only pausing when a video starts to play

thanks for mentioning, we will look into fixing this

VampireChicken12 avatar May 08 '24 00:05 VampireChicken12

Thanks! It also seems that any youtube page load causes the video to pause instead of only pausing when a video starts to play

thanks for mentioning, we will look into fixing this

thanks!

slrgt avatar May 20 '24 18:05 slrgt

@slrgt I think this has been fixed. I think the fix was added after the latest version, or maybe it wasn't mentioned in the update notes.

VampireChicken12 avatar May 20 '24 18:05 VampireChicken12

I haven't tested it.

VampireChicken12 avatar May 20 '24 18:05 VampireChicken12

Im on 1.2.5 and it still happens

On Mon, May 20, 2024 at 2:53 PM, Nathan @.***(mailto:On Mon, May 20, 2024 at 2:53 PM, Nathan < wrote:

I haven't tested it.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

slrgt avatar May 20 '24 18:05 slrgt

Im on 1.2.5 and it still happens

On Mon, May 20, 2024 at 2:53 PM, Nathan @.***(mailto:On Mon, May 20, 2024 at 2:53 PM, Nathan < wrote:

I haven't tested it.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

Oh okay. Can you attach a video of this happening or better instructions to reproduce the issue. Currently me and @livingflore are unsure on how to reproduce the bug.

VampireChicken12 avatar May 20 '24 18:05 VampireChicken12

Sure!

Here's a video:

https://github.com/YouTube-Enhancer/extension/assets/114287507/3cfe1f14-012a-40d0-903c-dad19a9c94b9

This happens regardless of what tab you're one even if its not a tab with youtube (im just clicking the play button and it tries to play then pauses so i click it again)

slrgt avatar May 20 '24 19:05 slrgt

@slrgt thank you. I'll watch the video when I get home. I just got done with my two puppies veterinarian visit. VideoCapture_20240520-150954.jpg

Oops, I selected the wrong image from my phone to upload

VampireChicken12 avatar May 20 '24 19:05 VampireChicken12

Cute puppy! I hope his vet visit went well!

slrgt avatar May 20 '24 19:05 slrgt

Cute puppy! I hope his vet visit went well!

Thanks his and her visit went well. I uploaded the wrong image on the last comment. I edited it.

VampireChicken12 avatar May 20 '24 19:05 VampireChicken12

I noticed that videos also pause if you open a youtube video in a new tab and dont even go to the tab even though the videos on the other tabs dont start

slrgt avatar Jun 30 '24 06:06 slrgt

I noticed that videos also pause if you open a youtube video in a new tab and dont even go to the tab even though the videos on the other tabs dont start

That maybe because of how the extension enables it's features. I will look into that.

VampireChicken12 avatar Jun 30 '24 06:06 VampireChicken12

Thanks!

slrgt avatar Jul 03 '24 15:07 slrgt

any update on this? its the only issue i come across everyday :/

slrgt avatar Sep 14 '24 17:09 slrgt

will look into it after finishing some other stuff, likely tomorrow

livingflore avatar Sep 14 '24 17:09 livingflore

Sweet thanks!

On Sat, Sep 14, 2024 at 1:39 PM, livingflore @.***(mailto:On Sat, Sep 14, 2024 at 1:39 PM, livingflore < wrote:

will look into it after finishing some other stuff, likely tomorrow

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

slrgt avatar Sep 15 '24 06:09 slrgt

sooo thing is that PiP web API is unavailable on firefox, and i'm not so sure how to fix it without reworking whole feature from scratch will think of something with Vamp on weekend hopefully

livingflore avatar Sep 19 '24 17:09 livingflore

I think the issue is that its pausing the video even if another youtube video isnt playing. If its on any other tab it cant start and it also pauses on other youtube tabs even if a video isnt started

On Thu, Sep 19, 2024 at 1:59 PM, livingflore @.***(mailto:On Thu, Sep 19, 2024 at 1:59 PM, livingflore < wrote:

sooo thing is that PiP web API is unavailable on firefox, and i'm not so sure how to fix it without reworking whole feature from scratch will think of something with Vamp on weekend hopefully

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

slrgt avatar Sep 19 '24 20:09 slrgt