extension icon indicating copy to clipboard operation
extension copied to clipboard

[Feature Request] Add ability to auto-maximize video to viewport dimensions on load

Open sjclayton opened this issue 2 years ago • 13 comments

Title pretty much sums it up, would like a way to have the maximize behavior that is triggered by the maximize button to occur when a video is initially loaded. Having a toggle for this in settings page would be awesome.

Thanks.

sjclayton avatar Dec 10 '23 10:12 sjclayton

@sjclayton Thanks for making an issue. I'll add that in the next update.

VampireChicken12 avatar Dec 10 '23 16:12 VampireChicken12

Hi @sjclayton,

While working on your requested feature, I noticed that the code for maximizing the player needs some cleaning up to smoothly integrate with the automatic maximize player feature. This cleanup might extend the time needed to finish your feature. Thanks for your understanding! 🛠️

VampireChicken12 avatar Dec 11 '23 09:12 VampireChicken12

If I could make an addendum to this feature. Could you also make it so you can still scroll the page with Maximize enabled? It was the one feature I liked most about another youtube addon before it broke.

happygolucky919 avatar Dec 26 '23 10:12 happygolucky919

@happygolucky919 I should be able to do that I think.

VampireChicken12 avatar Dec 26 '23 20:12 VampireChicken12

Feature menu is offset above the player controls way more than it should be when maximize player is enabled

Image

VampireChicken12 avatar Dec 30 '23 06:12 VampireChicken12

maximize-info

Just a bit of info I put into a file so I know what I have to do when re-writing the maximize player feature.

I'm working on making the feature actually proper right now it works but it relies on the theater mode being enabled which is janky. The list of things to be updated is what I have discovered that need adjusting ones with check marks I already know how to implement.

@sjclayton mentioning you to let you know I'm working on this the auto maximize feature shouldn't be delayed much longer after I finish determining what needs to be adjusted then implement that.

VampireChicken12 avatar Dec 31 '23 13:12 VampireChicken12

There is hope @sjclayton https://github.com/VampireChicken12/youtube-enhancer/commit/f97aa3bdbc9b4755861dbdfcb0e96dba4a473d39 sorry for taking so long. I just want to make the feature as good as possible.

VampireChicken12 avatar Jan 10 '24 22:01 VampireChicken12

@VampireChicken12

Any hope for this? It's one of the main things that is still missing for me in using this extension full time.

sjclayton avatar Aug 05 '24 21:08 sjclayton

@sjclayton I'm going to continue working on this. Are you okay with the seek preview being messed up until I figured out how to get it fixed. I was re-writing the maximize feature then I was going to implement this feature.

VampireChicken12 avatar Aug 05 '24 21:08 VampireChicken12

@VampireChicken12

The seek preview is working fine for me currently as far as I know... I'm using the last actual release as of now (1.26.0)

sjclayton avatar Aug 05 '24 22:08 sjclayton

@sjclayton yes in the current version it is but in the re-worked feature it doesn't work properly it. I can't show how it looks right now.

VampireChicken12 avatar Aug 05 '24 22:08 VampireChicken12

@VampireChicken12

Well keep working on it and release it when it's ready and functioning correctly... I can't have the seek preview not working right.

sjclayton avatar Aug 05 '24 22:08 sjclayton

@sjclayton okay, it works but it doesn't fit the the full size.

VampireChicken12 avatar Aug 05 '24 22:08 VampireChicken12