minecraft-optimization icon indicating copy to clipboard operation
minecraft-optimization copied to clipboard

Add wet-farmland

Open Pantera07 opened this issue 1 year ago • 5 comments
trafficstars

https://github.com/PaperMC/Paper/pull/9968

There are two options: dry-farmland and wet-farmland, the reason it is separate is because the performance impact of dry farmlands isn't that big, but has a big gameplay impact where players may be confused about why the farmland isn't wet after placing water near it. Yes, dry farmlands have the same isNearWater checks as wet farmlands, but dry farmlands do end up turning to regular dirt after a while, so it is like they are "naturally" throttled by the server.

Pantera07 avatar Dec 08 '23 19:12 Pantera07

I'm not sure if this is relevant. I haven't seen any spark reports or timings suggesting that farmland updates is something that has major impact on tps. Would appreciate such reports to illustrate the issue

YouHaveTrouble avatar Dec 08 '23 19:12 YouHaveTrouble

Large farms may cause lag. farmland searches for nearby blocks every tick.

Pantera07 avatar Dec 08 '23 20:12 Pantera07

Which in my minecraft optimization career I've seen exactly 0 times. If you're able to provide a spark from a server with the situation where farmland causes tps issues, I'll merge this

YouHaveTrouble avatar Dec 08 '23 20:12 YouHaveTrouble

I can confirm this uses 2-3% of my ticks on huge servers image

LuluxClient avatar Jul 22 '24 08:07 LuluxClient

spark report please

YouHaveTrouble avatar Jul 22 '24 08:07 YouHaveTrouble