certbot-zimbra icon indicating copy to clipboard operation
certbot-zimbra copied to clipboard

Certbot-auto deprecated, script stops on error not recognizing certbot version

Open cavp76 opened this issue 4 years ago • 5 comments

Hi:

New version of certbot (installed through snapd) makes certbot-zimbra unable to detect certbot:

[root@mail certbot-zimbra]# certbot --version
certbot 1.11.0
[root@mail certbot-zimbra]# ./certbot_zimbra.sh -n -j -c
certbot-zimbra v0.7.11 - https://github.com/YetOpen/certbot-zimbra
Checking for dependencies...
Detected Zimbra 8.8.15 on RHEL7_64
Using zmhostname to detect domain.
Using domain mail.domaintest.com (as certificate DN)
Is this correct? y
Detecting additional public service hostnames... Found 0 zimbraPublicServiceHostnames through auto-detection
Checking zimbra-proxy is running and enabled
Detecting port from zimbraMailProxyPort
Skipping port check
Nginx templates already patched.
Nginx includes already patched, skipping zmproxy restart.
Detecting certbot version...
Skipping bootstrap because certbot-auto is deprecated on this system.
Your system is not supported by certbot-auto anymore.
Certbot cannot be installed.
Please visit https://certbot.eff.org/ to check for other alternatives.
Error: certbot is too old, please upgrade to certbot >=0.19.0. Exiting.

Certbot-auto has been deprecated; check https://community.letsencrypt.org/t/certbot-auto-deprecated-explanation-and-solutions/139821

Please check it out; although Zimbra is being killed, people still use it.

Thanks

cavp76 avatar Jan 24 '21 22:01 cavp76

If you installed certbot, uninstall certbot-auto. The script prefers certbot-auto over certbot if it can find it in PATH. I haven't heard about the deprecation, if so it may make sense to move it down the list (to not break installs that still use it)

jjakob avatar Jan 24 '21 23:01 jjakob

OK, makes sense... but, this new installation method for certbot does NOT include certbot-auto:

[root@mail certbot-zimbra]# certbot-auto
Skipping bootstrap because certbot-auto is deprecated on this system.
Your system is not supported by certbot-auto anymore.
Certbot cannot be installed.
Please visit https://certbot.eff.org/ to check for other alternatives.

also, what to do about the version detection routine?

[root@mail certbot-zimbra]# certbot --version
certbot 1.11.0

The script detects it as "too old" :/

Thanks in advance

cavp76 avatar Jan 24 '21 23:01 cavp76

If the script detects certbot-auto, it uses it from then on. You can try deleting certbot-auto from line 387 of the script and try again. Or you can uninstall certbot-auto so it won't use it. If you did uninstall it and it thinks certbot 1.11.0 is older than 0.19.0, there must be a bug in the version comparison function, I'll need to take a look tomorrow.

jjakob avatar Jan 24 '21 23:01 jjakob

You were right, deleting the certbot-auto option from line 387 did it; thanks a lot.

cavp76 avatar Jan 24 '21 23:01 cavp76

#132

maxxer avatar May 13 '21 12:05 maxxer

Fixed in 1b6987c1

jjakob avatar Feb 26 '23 17:02 jjakob