Yellow-Dog-Man
Hide Badges on Stream Camera Huge FPS Drop
Describe the bug?
When I open the Stream Camera from the dash, and click the "Hide Badges" button. The FPS will go from like 50fps down to 15fps.
To Reproduce
Open the Stream Camera from the dash, and click the "Hide Badges" button.
Expected behavior
FPS to stay the same, and for it to act the same as if I told it to hide the badge directly in the dash.
Screenshots
No response
Resonite Version Number
2024.8.5.1341
What Platforms does this occur on?
Windows
What headset if any do you use?
Quest Pro
Log Files
DESKTOP-H0FLKOJ - 2024.8.5.1341 - 2024-08-26 21_48_12.log
Additional Context
I was in the "🌴 The Grand Oasis Karaoke" world with 29 other people
I also had TyraWhitetail in the world also test it, and he experienced the same issues.
BobTheGood was also nearby to witness it.
Reporters
troyBORG, TyraWhitetail
I believe this is due to Hide Badges using Exclude Renderer for every section of a badge:
Maybe these could use RTOs instead..?
Its not quite the list being there that's the issue, its that the list is generated when you check the box.
That list generation probably needs a review to see why its slow. Perhaps we could shunt the list generation to another thread too.
Oh I didn't mean to imply the list gen is the issue, multiple excludes can be really heavy on a camera in particular.
Oh that's good actually. It wasn't clear from me in the description if the FPS stayed low or went back up after a few ticks?
Is this a Hitch, or a permanent FPS drop until it is turned off?
I'm in a grid world with me and one other user, when after hitting Hide Badges I drop roughly 20fps from my max of 90. FPS stays that low before unchecking, and if I were hazard a guess, more users would greatly increase the drop as the original issue shows.
Was the other in world with @ohzee00, several of the items in the list they show were local assets. Not sure if it is related, just noticed it that there were several nulls in the list
Oh that's good actually. It wasn't clear from me in the description if the FPS stayed low or went back up after a few ticks?
Is this a Hitch, or a permanent FPS drop until it is turned off?
Oh yeah, you're right. I'm sorry, I forgot to include that. Yeah, for me, as soon as I clicked it, my FPS went low and stayed low until I unclicked it and then it would go back to normal.
Does this happen only if you're in a world with lots of users? If you do this with just a few users, is it fine?
ExcludeRender is somewhat expensive mechanism (which is one of the reasons why we don't want to add it to Mirrors/Portals), so we might need to investigate alternatives here, however knowing more could help, there could be some other pathological behaviors.
I don't see nulls causing any issues there, those should just be ignored.
Myself and @ohzee00 observed (ohzee's) FPS drop from solid 90 to ~65-70 just by toggling the setting with 2 people in a grid world.
@XDelta Are any of the people using custom badges? Or are they just the default ones?
Didn't explicitly check at the time. Probably some custom badges.
Just made an avatar out of 3 cubes so there is not custom anything and in a grid world. Also now disabled V-sync because otherwise hitting framerate limit. Even just solo I see a drop.
Grid world, solo, not hidden badges: 220-230 Grid world, solo, hidden badges: 180-185 Public world, 16 users, not hidden badges: 54-63 Public world, 16 users, hidden badges: 24-28