VSCodeExtension icon indicating copy to clipboard operation
VSCodeExtension copied to clipboard

Duplicate node title error between files

Open krispya opened this issue 2 years ago • 2 comments

What is the current behavior?

I have two .yarn files that each have a node named 'Start'. It gives the error More than one node is named Start even though it is valid to repeat names between files.

Please provide the steps to reproduce, and if possible a minimal demo of the problem:

Create two .yarn files and name the nodes the same in each.

What is the expected behavior?

I expect to only get this error if two nodes in the same file are named the same. As far as I know, this is expected by spec: https://github.com/YarnSpinnerTool/YarnSpinner/blob/9275277f50a6acbe8438b29596acc8527cf5581a/Documentation/Yarn-Spec.md#title-tag

Please tell us about your environment:

I'm using Yarn in JS.

  • Extension Version: v2.2.128

krispya avatar Oct 10 '23 02:10 krispya

Anyone planning on fixing this? Maybe I can submit a PR

warent avatar Jun 10 '24 23:06 warent

Actually I think this is the correct behavior because of the concept of a yarn project which compiles multiple files into a single context. So basically there just needs to be concept of namespaces / project spaces, or something. Seems like a larger architectural decision beyond me.

warent avatar Jun 11 '24 01:06 warent