extract-xiso icon indicating copy to clipboard operation
extract-xiso copied to clipboard

Needs build-essential

Open mossplains opened this issue 3 years ago • 3 comments

Please specify in the compilation instructions in the readme that build-essential is needed for cmake to work. It's the one piece I was missing and kept getting errors without it. I'm on Ubuntu 22.04.

mossplains avatar Aug 07 '22 06:08 mossplains

Well as the name suggests, I think it'd be implied that you'd need that on Debian based systems. Also the current list of required packages should work on all major operating systems, whilst build-essential is Debian only, causing other people to have issues with installing the dependencies on distros such as Arch which don't have a build-essential package (Arch has base-devel instead)

ExoSkye avatar Aug 07 '22 07:08 ExoSkye

The instructions should be changed, so instead of gcc, a working C compiler is expected (which would include build-essential or base-devel... or whatever your platform requires). What is required for each compiler and how it is shipped will depend on your target platform. We should avoid platform specific install instructions for such a simple CLI app.

Other than that, the code should be somewhat portable (it actually isn't, see #29 - which is also pinned). Looks like there's no gcc specific attributes or pragmas yet (why? shouldn't this be using packed structs?).

JayFoxRox avatar Aug 07 '22 09:08 JayFoxRox

Since no binary is being provided for Linux and the installation instructions are to compile yourself, I should hope that you would make it beginner-friendly enough by providing the complete instructions one what one needs to do on a fresh install of an OS in order to compile the app. I'm a programmer, but I completely forgot about build-essential and I'm on a fresh install that I haven't used for programming, so I was mystified as to why cmake wasn't working.

mossplains avatar Aug 07 '22 10:08 mossplains