AspNetCore.Diagnostics.HealthChecks
AspNetCore.Diagnostics.HealthChecks copied to clipboard
SendGrid ServiceProvider Overload
What this PR does / why we need it:
Adds an IServiceProvider overload for configuring SendGrid to allow for ApiKey to be pulled from DI (via options pattern, etc)
Which issue(s) this PR fixes:
Please reference the issue this PR will close: #2300
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Not really, no breakages, just a new overload
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [x] Code compiles correctly
- [x] Created/updated tests
- [x] Unit tests passing
- [x] End-to-end tests passing
- [x] Extended the documentation - n/a?
- [x] Provided sample for the feature - tests are the sample?
idk who approved the workflow previously, but thank you 😄
I have updated the public api txt file
can i get this merged?
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 64.02%. Comparing base (
4a49dfa) to head (f2ac47f). Report is 41 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #2301 +/- ##
==========================================
- Coverage 64.25% 64.02% -0.24%
==========================================
Files 248 247 -1
Lines 8399 8291 -108
Branches 590 574 -16
==========================================
- Hits 5397 5308 -89
+ Misses 2853 2839 -14
+ Partials 149 144 -5
| Flag | Coverage Δ | |
|---|---|---|
| SendGrid | 17.21% <100.00%> (+4.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.