xrpl-dev-portal icon indicating copy to clipboard operation
xrpl-dev-portal copied to clipboard

Airgapped wallet (py): slim down dependencies & update to xrpl-py 3.0.0

Open mDuo13 opened this issue 1 year ago • 2 comments

Most of the dependencies listed in the requirements.txt were either not actually used or were indirect dependencies (so it's better not to list them and let pip figure out the correct ones based on the explicit dependencies' versions).

I trimmed it down to just the ones that are used, and updated the code to work with xrpl-py 3.0.0, which has breaking changes in submit_and_wait (which now uses rippled API v2). In the process I cleared up some discrepancies in the described format of the signed transaction (transaction blob vs dictionary) and a couple small usage things.

Supersedes #2803.

mDuo13 avatar Oct 11 '24 21:10 mDuo13

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

socket-security[bot] avatar Oct 11 '24 21:10 socket-security[bot]