xrpl-dev-portal icon indicating copy to clipboard operation
xrpl-dev-portal copied to clipboard

Published 20 hours ago • verified publisher icon XRPLF

[es-ES] First batch spanish translations

Open Ekiserrepe opened this issue 1 year ago • 7 comments

Ekiserrepe avatar Apr 02 '24 19:04 Ekiserrepe

Thank you for your contribution - this looks great for the first batch! Added suggestions to fix broken links. Also, recommend adding a translations.yaml file under the @i18n\es-ES\ similar to https://github.com/XRPLF/xrpl-dev-portal/blob/master/%40i18n/ja/translations.yaml before merging the first batch for Spanish translations.

Thanks for the review, I'll prepare the translations.yaml. Should I close the PR until then?

Ekiserrepe avatar Apr 04 '24 17:04 Ekiserrepe

Thank you! You could leave the PR open if you anticipate this work to take a few days to about a week. If you expect it to take longer, then it may be better to close the PR for now.

amarantha-k avatar Apr 04 '24 23:04 amarantha-k

@amarantha-k i think i added the translations.yaml file. Could you check it, please? Thank you!

Ekiserrepe avatar Apr 05 '24 20:04 Ekiserrepe

Added @i18n/es-ES/docs/concepts/ledgers folder and files translated.

Ekiserrepe avatar Apr 07 '24 16:04 Ekiserrepe

@Ekiserrepe Thank you! I was able to test locally with the translations.yaml file you added.

amarantha-k avatar Apr 09 '24 22:04 amarantha-k

FYI, waiting on a few localization fixes from Redocly - #2524, #2516, #2425

amarantha-k avatar Apr 16 '24 17:04 amarantha-k

Added /networks-and-servers translations

Ekiserrepe avatar Apr 21 '24 18:04 Ekiserrepe