xrpl-dev-portal icon indicating copy to clipboard operation
xrpl-dev-portal copied to clipboard

DGE-94-Cryptographic-Key-Derivation

Open interc0der opened this issue 3 years ago • 1 comments

Bounty pull request for 0031 - DGE-94-Cryptographic-Key-Derivation

interc0der avatar Sep 13 '22 13:09 interc0der

Good start of implementation using existing xrpl-js tools, could you add some tests?

jonathanlei avatar Sep 15 '22 20:09 jonathanlei

For context this is referring to the xrpl.js code snippets bounty: https://github.com/XRPLBounties/Proposals/blob/main/bounties/0031%20JavaScript%20Code%20Samples.md

JST5000 avatar Sep 27 '22 21:09 JST5000

For this bounty the goal is to have feature parity with these snippets so they can be used interchangeably depending on what language the new reader is most comfortable with: https://github.com/XRPLF/xrpl-dev-portal/tree/master/content/_code-samples/key-derivation/py

And specifically, the snippets are supposed to give a concrete way to understand these high-ish level concepts: https://xrpl.org/cryptographic-keys.html#key-derivation

So instead of using the client library to abstract away the details of the encode/decode, it's actually important to step through it and add comments explaining the intent. (The python one has some of those comments, and the high level concept also may have some useful things to point out in the code)

JST5000 avatar Sep 29 '22 21:09 JST5000

Hey @interc0der I'm closing this PR as we have accepted a different submission for this bounty (https://github.com/XRPLF/xrpl-dev-portal/pull/1507).

JST5000 avatar Oct 13 '22 21:10 JST5000