xrpl-dev-portal icon indicating copy to clipboard operation
xrpl-dev-portal copied to clipboard

Added Python code samples for escrows

Open ObiajuluM opened this issue 3 years ago • 1 comments

Python code sample - Create, finish and cancel escrows using conditional and time-based release, view account escrows

Bounty DGE-93 milestone 2

Find changes here

If you are impressed by the code and how detailed it is check out what I am doing with Mint Engine

ObiajuluM avatar Sep 03 '22 08:09 ObiajuluM

Done

ObiajuluM avatar Sep 07 '22 04:09 ObiajuluM

Here's the updated link to the bounty referred to in this PR: https://github.com/XRPLBounties/Proposals/blob/main/bounties/0032%20Python%20Code%20Samples.md

JST5000 avatar Sep 27 '22 21:09 JST5000

I'll aim to review your PRs tomorrow - sorry for the delay! (I recently realized my notifications for this repo were being suppressed)

JST5000 avatar Oct 12 '22 21:10 JST5000

Can you go through and double check that everything runs locally then re-request my review? Happy to check again after that :)

JST5000 avatar Oct 13 '22 23:10 JST5000

@JST5000 all done

ObiajuluM avatar Oct 16 '22 03:10 ObiajuluM

Sorry for all that, I've made the changes. The code runs fine on my system

ObiajuluM avatar Oct 18 '22 04:10 ObiajuluM

All done @JST5000

ObiajuluM avatar Oct 25 '22 09:10 ObiajuluM