DRAFT: rabbit hole: refactor dirAdd to find gaps in "full" directories.

[ximinez]

I was looking at how dirAdd works. There have been complaints that when an account's directory gets "full", it is very difficult to free it back up, even though there may be many many partial pages, and many gaps in the linked list of directories.

• This would potentially be very expensive to implement, so don't.
• However, it might be a good start for a ledger fix option.

High Level Overview of Change

Context of Change

Type of Change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Refactor (non-breaking change that only restructures code)
• [ ] Performance (increase or change in throughput and/or latency)
• [ ] Tests (you added tests for code that already exists, or your new feature included in this PR)
• [ ] Documentation update
• [ ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• [ ] Release

API Impact

• [ ] Public API: New feature (new methods and/or new fields)
• [ ] Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• [ ] libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• [ ] Peer protocol change (must be backward compatible or bump the peer protocol version)

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 70.42254% with 21 lines in your changes missing coverage. Please review.

Project coverage is 78.1%. Comparing base (1c99ea2) to head (50363f2).

Files with missing lines	Patch %	Lines
src/xrpld/ledger/detail/ApplyView.cpp	70.4%	21 Missing :warning:

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5362     +/-   ##
=========================================
- Coverage     78.1%   78.1%   -0.0%     
=========================================
  Files          795     795             
  Lines        68598   68634     +36     
  Branches      8281    8289      +8     
=========================================
+ Hits         53584   53602     +18     
- Misses       15014   15032     +18     

Files with missing lines	Coverage Δ
src/xrpld/ledger/detail/ApplyView.cpp	66.8% <70.4%> (-4.3%)	:arrow_down:

... and 4 files with indirect coverage changes

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[intelliot]

There have been complaints that when an account's directory gets "full", it is very difficult to free it back up, even though there may be many many partial pages, and many gaps in the linked list of directories.

Just curious - where are these complaints? I don't recall seeing them