Additional support in ledger_entry
close #5198
High Level Overview of Change
Context of Change
Type of Change
- [x ] New feature (non-breaking change which adds functionality)
API Impact
- [x ] Public API: New feature (new methods and/or new fields)
Codecov Report
Attention: Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review.
Project coverage is 79.1%. Comparing base (
e2fa5c1) to head (1400086). Report is 35 commits behind head on develop.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/xrpld/rpc/handlers/LedgerEntry.cpp | 82.2% | 8 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #5236 +/- ##
=======================================
Coverage 79.1% 79.1%
=======================================
Files 817 817
Lines 71703 71748 +45
Branches 8238 8242 +4
=======================================
+ Hits 56715 56753 +38
- Misses 14988 14995 +7
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/xrpld/rpc/handlers/LedgerEntry.cpp | 79.5% <82.2%> (+0.6%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
I think the API for the singletons like amendments deserves a bit more discussion. I'm not entirely convinced that a boolean is the right way to go about it (but I'm also not sure what the right way should be).
@tequdev We'll pick this one up soon - would you be able to resolve the conflicts?
@tequdev We'll pick this one up soon - would you be able to resolve the conflicts?
done ✅
@bthomee I think this PR might be superseded by #5237