rippled icon indicating copy to clipboard operation
rippled copied to clipboard

Add nftoken_id, nftoken_ids, offer_id to meta for transaction stream

Open tequdev opened this issue 11 months ago • 6 comments

High Level Overview of Change

As the title says.

Type of Change

  • [x ] Bug fix (non-breaking change which fixes an issue)

close #5229

tequdev avatar Dec 20 '24 06:12 tequdev

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.1%. Comparing base (1e01cd3) to head (f8efb5a). Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5230     +/-   ##
=========================================
- Coverage     79.1%   79.1%   -0.0%     
=========================================
  Files          817     817             
  Lines        71704   71704             
  Branches      8260    8259      -1     
=========================================
- Hits         56731   56698     -33     
- Misses       14973   15006     +33     
Files with missing lines Coverage Δ
src/libxrpl/protocol/NFTSyntheticSerializer.cpp 100.0% <ø> (ø)
src/xrpld/app/misc/NetworkOPs.cpp 70.5% <100.0%> (+<0.1%) :arrow_up:
src/xrpld/rpc/handlers/AccountTx.cpp 87.9% <100.0%> (ø)
src/xrpld/rpc/handlers/Tx.cpp 93.3% <100.0%> (ø)

... and 14 files with indirect coverage changes

Impacted file tree graph

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 20 '24 06:12 codecov[bot]

Please add tests

mvadari avatar Dec 20 '24 21:12 mvadari

Please add tests

added

tequdev avatar Dec 22 '24 06:12 tequdev

This would require a small update in clio to update its subscription as well. cc @kennyzlei @godexsoft

shawnxie999 avatar Apr 11 '25 13:04 shawnxie999

@tequdev may I ask you to merge latest rippled to your branch?

I would like to work on clio side, but it won't be possible with outdated branch.

mathbunnyru avatar May 27 '25 15:05 mathbunnyru

@mathbunnyru merged

tequdev avatar May 29 '25 08:05 tequdev

@tequdev: ready to merge?

bthomee avatar Jun 23 '25 18:06 bthomee

@tequdev: ready to merge?

yes💪

tequdev avatar Jun 24 '25 00:06 tequdev