rippled icon indicating copy to clipboard operation
rippled copied to clipboard

Oracle ledger object does not expose OracleDocumentID field (Version: rippled-2.2.3)

Open pkcs8 opened this issue 1 year ago • 1 comments

Issue Description

OracleDocumentID is an important field for Oracle objects. It is a required field while creating a new Oracle, but rippled doesn't return this field when querying the ledger object via ledger_entry, account_objects and possibly other methods.

If OracleDocumentID is not discoverable via available methods, it would be difficult to delete the Oracle since OracleDelete transaction takes OracleDocumentID as a required parameter.

Steps to Reproduce

Fetch an Oracle object using ledger_entry command.

curl -H 'Content-Type: application/json' -d '{"method":"ledger_entry","params":[{"index":"28716548F718BE307D1492BABDF21C5D71CD8248F6D5FC591BE598E6BC6E2692","ledger_index":"validated"}]}' https://s1.ripple.com:51234/

Example: https://explorer.xrplf.org/entry/28716548F718BE307D1492BABDF21C5D71CD8248F6D5FC591BE598E6BC6E2692

Expected Result

Oracle object returned by rippled should contain OracleDocumentID field.

Actual Result

Oracle object returned by rippled does not contain OracleDocumentID field.

Environment

Using rippled-2.2.3.

Supporting Files

OracleDocumentID

pkcs8 avatar Nov 03 '24 20:11 pkcs8

OracleDocumentID seems to be missing from the Oracle object

https://github.com/XRPLF/rippled/blob/a76809a3fd3402f97d87fc3f3944108aedd81a6d/include/xrpl/protocol/detail/ledger_entries.macro#L384-L394

tequdev avatar Nov 04 '24 06:11 tequdev

Fixed by #5646

mvadari avatar Oct 14 '25 20:10 mvadari