rippled icon indicating copy to clipboard operation
rippled copied to clipboard

fix CTID in tx command returns invalidParams on lowercase hex

Open yinyiqian1 opened this issue 1 year ago • 1 comments

fix #4776

High Level Overview of Change

Context of Change

Type of Change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactor (non-breaking change that only restructures code)
  • [ ] Performance (increase or change in throughput and/or latency)
  • [ ] Tests (you added tests for code that already exists, or your new feature included in this PR)
  • [ ] Documentation update
  • [ ] Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • [ ] Release

API Impact

  • [ ] Public API: New feature (new methods and/or new fields)
  • [ ] Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • [ ] libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • [ ] Peer protocol change (must be backward compatible or bump the peer protocol version)

yinyiqian1 avatar Jun 20 '24 14:06 yinyiqian1

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.4%. Comparing base (a17ccca) to head (7da5cdd).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5049   +/-   ##
=======================================
  Coverage     71.4%   71.4%           
=======================================
  Files          796     796           
  Lines        67031   67031           
  Branches     10864   10863    -1     
=======================================
  Hits         47834   47834           
  Misses       19197   19197           
Files Coverage Δ
src/xrpld/rpc/CTID.h 100.0% <100.0%> (ø)

... and 3 files with indirect coverage changes

Impacted file tree graph

codecov[bot] avatar Jun 20 '24 15:06 codecov[bot]

@yinyiqian1, this pull request has two approvals. Are you ready for the pull request to be marked as passed? Let me know. Thanks.

scottschurr avatar Jul 05 '24 17:07 scottschurr

@yinyiqian1, this pull request has two approvals. Are you ready for the pull request to be marked as passed? Let me know. Thanks.

@scottschurr Yes. It can be marked as passed. Thank you Scott.

yinyiqian1 avatar Jul 05 '24 17:07 yinyiqian1