rippled icon indicating copy to clipboard operation
rippled copied to clipboard

Validation stream Network ID (Version: 1.12.0)

Open shortthefomo opened this issue 2 years ago • 3 comments

Summary

Network id is impossible to establish from the validation stream, the stream contains validators of all networks.

Motivation

Explorers, hosting tools, etc. Or anything try to validate data out of this stream will need to figure out which network the node is on.

Solution

Add a network_id field to the validation data returned in the stream of data https://xrpl.org/subscribe.html#validations-stream

Paths Not Taken

Unable to 100% say if the id is present in another hash or it could possibly be derived from something already present.

shortthefomo avatar Oct 24 '23 17:10 shortthefomo

Additionally/ideally, there would be no crosstalk between networks. Nodes should not connect to, nor gossip messages from, nodes on other networks.

intelliot avatar Oct 27 '23 05:10 intelliot

+1 from my side. Adding NetworkID to the validation stream would clean up a lot of code that consumes validations.

pkcs8 avatar Feb 07 '24 13:02 pkcs8

It would also be nice if this could be added to the ledger stream, if you're listening to multiple networks.

mvadari avatar Feb 07 '24 14:02 mvadari