rippled icon indicating copy to clipboard operation
rippled copied to clipboard

Published 20 hours ago • verified publisher icon XRPLF

p2p fail with "bad message"

Open halberdholder opened this issue 3 years ago • 2 comments

When read a p2p stream and committed message to the read buffer, if the message flow includes two protocol packages, which will lead to a bad message error and p2p fail by it. Case compression closed, the following code ParseFromZeroCopyStream won't be succeed.

https://github.com/ripple/rippled/blob/34786abd4ff06f80022024d177e0d7dbf97abda9/src/ripple/overlay/impl/ProtocolMessage.h#L295

halberdholder avatar May 23 '22 08:05 halberdholder

Interesting issue. Thank you for contributing a proposed fix; the change will be reviewed for inclusion in the next release.

nbougalis avatar May 24 '22 04:05 nbougalis

@nbougalis what are your latest thoughts on this issue?

(Given we don't know how to reproduce it, we are inclined to close the issue until we get more information.)

intelliot avatar Jan 11 '23 17:01 intelliot