rippled
rippled copied to clipboard
Delivered_amount updates needed
Two issues with delivered_amount:
- If you request a ledger with expanded transactions, delivered_amount is not included. It should be.
- For ledgers before the cutoff, we should not report delivered_amount as unknown if the partial payment flag isn't set – the payment must have delivered the full amount.
- Do a sanity check on all other areas that should have delivered_amount - and fix any missing delivered_amount.
Exported from RIPD-1232
Regarding concern 1, I just submitted the following query to a local node that was running 2.0.0-rc4 ...
{
"id" : wsid,
"command" : "ledger",
"ledger_index" : 84368639,
"binary" : False,
"expand" : True,
"transactions" : True
}
The returned Payment transactions included delivered_amount fields. So it looks like concern 1 has been addressed already.
Regarding concern 2, the cutoff referred to in that sentence is during February of 2014. That cutoff is almost 10 years ago now. The response is, "unavailable". We could potentially look at the flags for very old transactions to see if the tfPartialPayment flag is set. But is the change worth it for transactions that are 10 years old or older? This question should be answered for both clio and rippled, since both would require the change.