flask-log-request-id icon indicating copy to clipboard operation
flask-log-request-id copied to clipboard

init_app should not reference self.

Open nickelwound opened this issue 5 years ago • 1 comments
trafficstars

This line appears to break the following common pattern:

def create_app():
    """Bootstrap the app. Takes an instance of the Flask obj/app."""
    app = Flask(__name__)
    request_id = RequestID()
    request_id.init_app(app)
    return app

traceback:

    request_id.init_app(app)
  File "/usr/local/lib/python3.7/site-packages/flask_log_request_id/request_id.py", line 84, in init_app
    if self.app.config['LOG_REQUEST_ID_LOG_ALL_REQUESTS']:
AttributeError: 'NoneType' object has no attribute 'config'

When init_app is called, self.app has not been assigned. It should use the passed app object.

nickelwound avatar Jan 22 '20 16:01 nickelwound

Seems to have been fixed in #38 but not released.

arrdem avatar Dec 31 '20 00:12 arrdem