wordpress-develop icon indicating copy to clipboard operation
wordpress-develop copied to clipboard

Add wp_prime_network_option_caches function in option.php

Open spacedmonkey opened this issue 1 year ago • 4 comments

Introduced the new function wp_prime_network_option_caches in option.php. This function simplifies the handling of network option caches, enhancing the speed of operations. In the wp_load_core_site_options function, removed cache processing code and replaced it with a call to the new function. These changes improve code efficiency and readability.

Trac ticket: https://core.trac.wordpress.org/ticket/61053


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

spacedmonkey avatar Mar 22 '24 17:03 spacedmonkey

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions[bot] avatar Mar 22 '24 17:03 github-actions[bot]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @jonnynews.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props spacedmonkey, peterwilsoncc, mukesh27, joemcgill.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar May 13 '24 09:05 github-actions[bot]

Amazing feedback @peterwilsoncc . It is really appricated. Your best code review! Legend.

spacedmonkey avatar May 18 '24 18:05 spacedmonkey

Thanks for the feedback @joemcgill . Actioned feedback.

spacedmonkey avatar May 20 '24 21:05 spacedmonkey

Committed https://github.com/WordPress/wordpress-develop/commit/6662cb0bef6bdd3fd2aa02db92f5781a4b5db657

spacedmonkey avatar May 21 '24 21:05 spacedmonkey