openverse-frontend icon indicating copy to clipboard operation
openverse-frontend copied to clipboard

Update the meta search section with the new design

Open fcoveram opened this issue 3 years ago • 3 comments

Problem

The current meta search area in search results does not follow the redesign.

CleanShot 2022-01-27 at 11 59 18@2x

Description

We need to update the section with the design made on the mockups.

Desktop version

Meta search on desktop

Mobile version

Meta search on mobile

fcoveram avatar Jan 27 '22 15:01 fcoveram

Currently we have two ways in which the meta-search feature is reached.

  • a search has zero results
Screenshot 2022-06-28 at 11 35 35 AM
  • below the load more button of the search results
Screenshot 2022-06-28 at 11 37 50 AM

@panchovm does this redesign only affect the second appearance?

dhruvkb avatar Jun 28 '22 07:06 dhruvkb

Yes @dhruvkb, only the second appearance. Although I would pause this work until we have a decision regarding keeping using the term "Additional."

fcoveram avatar Jun 28 '22 14:06 fcoveram

Good call @panchovm. I'll triage this issue as blocked for now.

dhruvkb avatar Jun 28 '22 14:06 dhruvkb

@panchovm, we have already decided on renaming the feature to "External sources". Can we update the status of this issue?

Currently, meta search section uses a popover on all layouts: desktop and mobile, the bottom of the search results and the page shown when nothing could be found:

Desktop

Screenshot 2022-11-20 at 7 11 45 AM

Mobile

Screenshot 2022-11-20 at 7 12 21 AM

"Nothing found" page

Screenshot 2022-11-20 at 7 12 57 AM

From the comments on this issue, I understand we should do the following:

  1. Use a modal for the mobile source selector instead of a Popover.
  2. Use a button row for the list of external sources on the "Nothing found" page.

Is this correct, is there anything we need to add?

obulat avatar Nov 20 '22 04:11 obulat

You are right @obulat, the term no longer blocks the ticket.

Although this issue only covers point 1 in the way you describe it. For point 2, I think we do not have the ticket requesting the update or the mockup.

fcoveram avatar Nov 21 '22 13:11 fcoveram

I've updated the issue to only include the mobile fix; #1999 will cover the changes necessary for "No results" page.

obulat avatar Nov 21 '22 14:11 obulat