openverse-frontend icon indicating copy to clipboard operation
openverse-frontend copied to clipboard

Add types to VModal components

Open obulat opened this issue 3 years ago • 0 comments

Description

Add type checking to components inside VModal. Make sure to add the directory to tsconfig.json's include list.

Additional context The VModalContent imports an SVG logo converting it to a component with ?inline, which cannot be type-checked. It should be replaced with an svg element similar to how it's used in VIcon. Part of an ongoing effort to add type checking to parts of the project that can be type checked.

Implementation

  • [x] 🙋 I would be interested in implementing this feature.

obulat avatar Oct 20 '22 05:10 obulat