openverse-frontend
openverse-frontend copied to clipboard
Published
20 hours ago âĸ
WordPress
WordPress
Add the new VR tests with `new_header` flag turned on
Fixes
Related to #1843 by @dhruvkb
Description
This PR was originally created to add new visual regression tests for pages and components when new_header flag is turned on. So, it fixes the describeEachMobile breakpoint testing function to include md (as now it's using the mobile layout, not the desktop one) and adds the new tests.
However, while working on it, I also found other changes that needed to be updated. I recently set maxDiffPixelRatio in Playwright config to 0.06 out of frustration with the flaky component tests, when if a component shifted 1 px down, the test was failing. When I set it back to the previous value of 0.02, I saw a lot of small changes that have crept up into main recently :(
- #1916 has tried to fix the Get media button height by adding
self-centerclass to it. The problem was that the class was added to the baseVButtoncomponent, which affected other buttons (e.g., the Copy button inside the license panel became centered) - This is fixed in #1930 - The buttons in the
oldheader became taller (50px instead of 48px) because the Openverse Logo changed its height to 50px, and the buttons stretched to the full height of the logo. - License heading on the single result page was not bold because it was using a non-existent
descriptionclass instead ofdescription-bold.
Testing Instructions
The CI should pass, and the snapshots should look well and match the designs.
Checklist
- [ ] My pull request has a descriptive title (not a vague title like
Update index.md). - [ ] My pull request targets the default branch of the repository (
main) or a parent feature branch. - [ ] My commit messages follow best practices.
- [ ] My code follows the established code style of the repository.
- [ ] I added or updated tests for the changes I made (if applicable).
- [ ] I added or updated documentation (if applicable).
- [ ] I tried running the project locally and verified that there are no visible errors.
Developer Certificate of Origin
Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Storybook and Tailwind configuration previews: Ready
Storybook: https://wordpress.github.io/openverse-frontend/_preview/1919 Tailwind: https://wordpress.github.io/openverse-frontend/_preview/1919/tailwind
Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.
You can check the GitHub pages deployment action list to see the current status of the deployments.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Size Change: -2.13 kB (0%)
Total Size: 813 kB
| Filename | Size | Change | |
|---|---|---|---|
./.nuxt/dist/client/231.js |
0 B | -272 B (removed) | đ |
./.nuxt/dist/client/231.modern.js |
0 B | -277 B (removed) | đ |
./.nuxt/dist/client/232.js |
0 B | -1.85 kB (removed) | đ |
./.nuxt/dist/client/app.js |
131 kB | -981 B (-1%) | |
./.nuxt/dist/client/app.modern.js |
122 kB | -1.02 kB (-1%) | |
./.nuxt/dist/client/commons/app.js |
88.1 kB | -17 B (0%) | |
./.nuxt/dist/client/pages/image/_id.js |
5.23 kB | -56 B (-1%) | |
./.nuxt/dist/client/pages/search/index.js |
2.97 kB | +14 B (0%) | |
./.nuxt/dist/client/runtime.js |
2.66 kB | -40 B (-1%) | |
./.nuxt/dist/client/runtime.modern.js |
2.66 kB | -40 B (-1%) | |
./.nuxt/dist/client/vendors/app.js |
57.3 kB | +48 B (0%) | |
./.nuxt/dist/client/223.js |
272 B | +272 B (new file) | đ |
./.nuxt/dist/client/223.modern.js |
277 B | +277 B (new file) | đ |
./.nuxt/dist/client/224.js |
1.85 kB | +1.85 kB (new file) | đ |
âšī¸ View Unchanged
| Filename | Size | Change |
|---|---|---|
./.nuxt/dist/client/commons/app.modern.js |
77 kB | +3 B (0%) |
./.nuxt/dist/client/components/loading-icon.js |
745 B | +1 B (0%) |
./.nuxt/dist/client/components/loading-icon.modern.js |
750 B | -1 B (0%) |
./.nuxt/dist/client/components/table-sort-icon.js |
509 B | 0 B |
./.nuxt/dist/client/components/table-sort-icon.modern.js |
513 B | 0 B |
./.nuxt/dist/client/components/v-all-results-grid.js |
2.76 kB | 0 B |
./.nuxt/dist/client/components/v-all-results-grid.modern.js |
2.73 kB | 0 B |
./.nuxt/dist/client/components/v-all-results-grid/pages/search/audio/pages/search/index.js |
3.02 kB | -3 B (0%) |
./.nuxt/dist/client/components/v-all-results-grid/pages/search/audio/pages/search/index.modern.js |
2.91 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-audio-cell.js |
357 B | +1 B (0%) |
./.nuxt/dist/client/components/v-audio-cell.modern.js |
362 B | +3 B (+1%) |
./.nuxt/dist/client/components/v-audio-details.js |
1.81 kB | 0 B |
./.nuxt/dist/client/components/v-audio-details.modern.js |
1.79 kB | 0 B |
./.nuxt/dist/client/components/v-audio-track-skeleton.js |
1.01 kB | 0 B |
./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js |
1.02 kB | 0 B |
./.nuxt/dist/client/components/v-audio-track.js |
5.12 kB | -2 B (0%) |
./.nuxt/dist/client/components/v-audio-track.modern.js |
5.07 kB | +3 B (0%) |
./.nuxt/dist/client/components/v-back-to-search-results-link.js |
536 B | -1 B (0%) |
./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js |
541 B | 0 B |
./.nuxt/dist/client/components/v-bone.js |
685 B | 0 B |
./.nuxt/dist/client/components/v-bone.modern.js |
689 B | -1 B (0%) |
./.nuxt/dist/client/components/v-box-layout.js |
1.2 kB | 0 B |
./.nuxt/dist/client/components/v-box-layout.modern.js |
1.2 kB | -2 B (0%) |
./.nuxt/dist/client/components/v-content-link.js |
1.12 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-content-link.modern.js |
1.09 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-content-page.js |
467 B | 0 B |
./.nuxt/dist/client/components/v-content-page.modern.js |
471 B | 0 B |
./.nuxt/dist/client/components/v-content-report-button.js |
777 B | +1 B (0%) |
./.nuxt/dist/client/components/v-content-report-button.modern.js |
784 B | 0 B |
./.nuxt/dist/client/components/v-content-report-form.js |
3.75 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-content-report-form.modern.js |
3.56 kB | +2 B (0%) |
./.nuxt/dist/client/components/v-content-report-popover.js |
4.41 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-content-report-popover.modern.js |
4.21 kB | -4 B (0%) |
./.nuxt/dist/client/components/v-copy-button.js |
3.98 kB | -3 B (0%) |
./.nuxt/dist/client/components/v-copy-button.modern.js |
3.99 kB | -4 B (0%) |
./.nuxt/dist/client/components/v-copy-license.js |
998 B | -1 B (0%) |
./.nuxt/dist/client/components/v-copy-license.modern.js |
999 B | -1 B (0%) |
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.js |
9.5 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.modern.js |
9.48 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-dmca-notice.js |
748 B | 0 B |
./.nuxt/dist/client/components/v-dmca-notice.modern.js |
753 B | +1 B (0%) |
./.nuxt/dist/client/components/v-error-image.js |
1.69 kB | 0 B |
./.nuxt/dist/client/components/v-error-image.modern.js |
1.68 kB | -3 B (0%) |
./.nuxt/dist/client/components/v-error-section.js |
372 B | 0 B |
./.nuxt/dist/client/components/v-error-section.modern.js |
376 B | 0 B |
./.nuxt/dist/client/components/v-external-search-form.js |
3.09 kB | +2 B (0%) |
./.nuxt/dist/client/components/v-external-search-form.modern.js |
3.06 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-external-source-list.js |
2.55 kB | +2 B (0%) |
./.nuxt/dist/client/components/v-external-source-list.modern.js |
2.52 kB | 0 B |
./.nuxt/dist/client/components/v-full-layout.js |
1.48 kB | -3 B (0%) |
./.nuxt/dist/client/components/v-full-layout.modern.js |
1.49 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-grid-skeleton.js |
1.6 kB | -3 B (0%) |
./.nuxt/dist/client/components/v-grid-skeleton.modern.js |
1.61 kB | 0 B |
./.nuxt/dist/client/components/v-image-cell-square.js |
1.02 kB | 0 B |
./.nuxt/dist/client/components/v-image-cell-square.modern.js |
1.02 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-image-cell.js |
1.43 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-image-cell.modern.js |
1.42 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-image-details.js |
1.44 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-image-details.modern.js |
1.44 kB | +3 B (0%) |
./.nuxt/dist/client/components/v-image-grid.js |
2.54 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-image-grid.modern.js |
2.42 kB | -5 B (0%) |
./.nuxt/dist/client/components/v-license-tab-panel.js |
521 B | 0 B |
./.nuxt/dist/client/components/v-license-tab-panel.modern.js |
525 B | 0 B |
./.nuxt/dist/client/components/v-load-more.js |
790 B | 0 B |
./.nuxt/dist/client/components/v-load-more.modern.js |
682 B | 0 B |
./.nuxt/dist/client/components/v-media-license.js |
800 B | 0 B |
./.nuxt/dist/client/components/v-media-license.modern.js |
809 B | +2 B (0%) |
./.nuxt/dist/client/components/v-media-reuse.js |
1.62 kB | -3 B (0%) |
./.nuxt/dist/client/components/v-media-reuse.modern.js |
1.61 kB | -3 B (0%) |
./.nuxt/dist/client/components/v-media-tag.js |
430 B | 0 B |
./.nuxt/dist/client/components/v-media-tag.modern.js |
434 B | 0 B |
./.nuxt/dist/client/components/v-no-results.js |
2.75 kB | +3 B (0%) |
./.nuxt/dist/client/components/v-no-results.modern.js |
2.72 kB | 0 B |
./.nuxt/dist/client/components/v-radio.js |
1.51 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-radio.modern.js |
1.47 kB | +2 B (0%) |
./.nuxt/dist/client/components/v-related-audio.js |
1.23 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-related-audio.modern.js |
1.23 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-related-images.js |
3.1 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-related-images.modern.js |
2.97 kB | -6 B (0%) |
./.nuxt/dist/client/components/v-report-desc-form.js |
966 B | -1 B (0%) |
./.nuxt/dist/client/components/v-report-desc-form.modern.js |
965 B | 0 B |
./.nuxt/dist/client/components/v-row-layout.js |
1.7 kB | 0 B |
./.nuxt/dist/client/components/v-row-layout.modern.js |
1.71 kB | 0 B |
./.nuxt/dist/client/components/v-scroll-button.js |
813 B | 0 B |
./.nuxt/dist/client/components/v-scroll-button.modern.js |
819 B | 0 B |
./.nuxt/dist/client/components/v-search-grid.js |
5.43 kB | +4 B (0%) |
./.nuxt/dist/client/components/v-search-grid.modern.js |
5.38 kB | -4 B (0%) |
./.nuxt/dist/client/components/v-search-results-title.js |
658 B | 0 B |
./.nuxt/dist/client/components/v-search-results-title.modern.js |
654 B | +3 B (0%) |
./.nuxt/dist/client/components/v-search-type-radio.js |
794 B | -1 B (0%) |
./.nuxt/dist/client/components/v-search-type-radio.modern.js |
769 B | 0 B |
./.nuxt/dist/client/components/v-server-timeout.js |
298 B | -1 B (0%) |
./.nuxt/dist/client/components/v-server-timeout.modern.js |
303 B | 0 B |
./.nuxt/dist/client/components/v-sketch-fab-viewer.js |
998 B | +1 B (0%) |
./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js |
895 B | 0 B |
./.nuxt/dist/client/components/v-skip-to-content-container.js |
886 B | -2 B (0%) |
./.nuxt/dist/client/components/v-skip-to-content-container.modern.js |
893 B | 0 B |
./.nuxt/dist/client/components/v-snackbar.js |
1.18 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-snackbar.modern.js |
1.19 kB | 0 B |
./.nuxt/dist/client/components/v-sources-table.js |
15.7 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-sources-table.modern.js |
15.7 kB | 0 B |
./.nuxt/dist/client/components/v-warning-suppressor.js |
298 B | 0 B |
./.nuxt/dist/client/components/v-warning-suppressor.modern.js |
303 B | +1 B (0%) |
./.nuxt/dist/client/pages/about.js |
1.06 kB | +1 B (0%) |
./.nuxt/dist/client/pages/about.modern.js |
1.07 kB | +1 B (0%) |
./.nuxt/dist/client/pages/audio/_id.js |
4.89 kB | -3 B (0%) |
./.nuxt/dist/client/pages/audio/_id.modern.js |
4.73 kB | -1 B (0%) |
./.nuxt/dist/client/pages/external-sources.js |
1.45 kB | 0 B |
./.nuxt/dist/client/pages/external-sources.modern.js |
1.45 kB | 0 B |
./.nuxt/dist/client/pages/feedback.js |
1.24 kB | -1 B (0%) |
./.nuxt/dist/client/pages/feedback.modern.js |
1.24 kB | +1 B (0%) |
./.nuxt/dist/client/pages/image/_id.modern.js |
7.24 kB | -4 B (0%) |
./.nuxt/dist/client/pages/index.js |
5 kB | +3 B (0%) |
./.nuxt/dist/client/pages/index.modern.js |
4.86 kB | -3 B (0%) |
./.nuxt/dist/client/pages/preferences.js |
1.21 kB | -2 B (0%) |
./.nuxt/dist/client/pages/preferences.modern.js |
1.21 kB | 0 B |
./.nuxt/dist/client/pages/search-help.js |
1.54 kB | 0 B |
./.nuxt/dist/client/pages/search-help.modern.js |
1.55 kB | 0 B |
./.nuxt/dist/client/pages/search.js |
2.72 kB | -3 B (0%) |
./.nuxt/dist/client/pages/search.modern.js |
2.57 kB | +1 B (0%) |
./.nuxt/dist/client/pages/search/audio.js |
1.23 kB | -4 B (0%) |
./.nuxt/dist/client/pages/search/audio.modern.js |
1.23 kB | -3 B (0%) |
./.nuxt/dist/client/pages/search/image.js |
2.79 kB | +9 B (0%) |
./.nuxt/dist/client/pages/search/image.modern.js |
2.67 kB | -2 B (0%) |
./.nuxt/dist/client/pages/search/index.modern.js |
2.94 kB | 0 B |
./.nuxt/dist/client/pages/search/model-3d.js |
243 B | 0 B |
./.nuxt/dist/client/pages/search/model-3d.modern.js |
247 B | 0 B |
./.nuxt/dist/client/pages/search/search-page.types.js |
265 B | -1 B (0%) |
./.nuxt/dist/client/pages/search/search-page.types.modern.js |
271 B | +1 B (0%) |
./.nuxt/dist/client/pages/search/video.js |
239 B | -1 B (0%) |
./.nuxt/dist/client/pages/search/video.modern.js |
244 B | 0 B |
./.nuxt/dist/client/pages/sources.js |
1.44 kB | -3 B (0%) |
./.nuxt/dist/client/pages/sources.modern.js |
1.45 kB | -2 B (0%) |
./.nuxt/dist/client/vendors/app.modern.js |
56.5 kB | +1 B (0%) |
The changes to the old_header height were extracted to #1944, and the changes to the breakpoints handling in Playwright tests were already merged in #1918. The changes to the Search button and the maxDiffPixelRatio will be handled in another PR.