openverse-frontend
openverse-frontend copied to clipboard
Published
20 hours ago âĸ
WordPress
WordPress
Refactor `VIcon` to set the size using a tailwind class instead of the `size` prop
trafficstars
Fixes
Fixes #1894 by @obulat
Description
This PR removes the numeric size prop from VIcon component. This is because there are too many sizes in the app to make it useful, especially since we have to add all the dynamically generated size classes (like w-${size} h-$size) to tailwind's safelist.
Testing Instructions
You can view the buttons in the Storybook.
Checklist
- [ ] My pull request has a descriptive title (not a vague title like
Update index.md). - [ ] My pull request targets the default branch of the repository (
main) or a parent feature branch. - [ ] My commit messages follow best practices.
- [ ] My code follows the established code style of the repository.
- [ ] I added or updated tests for the changes I made (if applicable).
- [ ] I added or updated documentation (if applicable).
- [ ] I tried running the project locally and verified that there are no visible errors.
Developer Certificate of Origin
Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Storybook and Tailwind configuration previews: Ready
Storybook: https://wordpress.github.io/openverse-frontend/_preview/1895 Tailwind: https://wordpress.github.io/openverse-frontend/_preview/1895/tailwind
Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.
You can check the GitHub pages deployment action list to see the current status of the deployments.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Size Change: -2.27 kB (0%)
Total Size: 821 kB
| Filename | Size | Change | |
|---|---|---|---|
./.nuxt/dist/client/230.js |
0 B | -272 B (removed) | đ |
./.nuxt/dist/client/230.modern.js |
0 B | -277 B (removed) | đ |
./.nuxt/dist/client/231.js |
0 B | -1.85 kB (removed) | đ |
./.nuxt/dist/client/app.js |
135 kB | -1.2 kB (-1%) | |
./.nuxt/dist/client/app.modern.js |
126 kB | -1.18 kB (-1%) | |
./.nuxt/dist/client/commons/app.modern.js |
77 kB | +10 B (0%) | |
./.nuxt/dist/client/components/v-all-results-grid.js |
2.76 kB | +12 B (0%) | |
./.nuxt/dist/client/components/v-all-results-grid.modern.js |
2.74 kB | +10 B (0%) | |
./.nuxt/dist/client/components/v-content-report-popover.js |
4.44 kB | +11 B (0%) | |
./.nuxt/dist/client/components/v-external-search-form.modern.js |
3.1 kB | +10 B (0%) | |
./.nuxt/dist/client/components/v-search-grid.modern.js |
5.42 kB | +11 B (0%) | |
./.nuxt/dist/client/components/v-sources-table.js |
15.7 kB | -24 B (0%) | |
./.nuxt/dist/client/components/v-sources-table.modern.js |
15.7 kB | -26 B (0%) | |
./.nuxt/dist/client/pages/image/_id.modern.js |
7.23 kB | +11 B (0%) | |
./.nuxt/dist/client/pages/search/index.js |
2.97 kB | +21 B (+1%) | |
./.nuxt/dist/client/runtime.js |
2.65 kB | -48 B (-2%) | |
./.nuxt/dist/client/runtime.modern.js |
2.65 kB | -48 B (-2%) | |
./.nuxt/dist/client/220.js |
272 B | +272 B (new file) | đ |
./.nuxt/dist/client/220.modern.js |
276 B | +276 B (new file) | đ |
./.nuxt/dist/client/221.js |
1.85 kB | +1.85 kB (new file) | đ |
âšī¸ View Unchanged
| Filename | Size | Change |
|---|---|---|
./.nuxt/dist/client/commons/app.js |
88.2 kB | +2 B (0%) |
./.nuxt/dist/client/components/loading-icon.js |
746 B | +1 B (0%) |
./.nuxt/dist/client/components/loading-icon.modern.js |
750 B | +1 B (0%) |
./.nuxt/dist/client/components/table-sort-icon.js |
509 B | 0 B |
./.nuxt/dist/client/components/table-sort-icon.modern.js |
514 B | 0 B |
./.nuxt/dist/client/components/v-all-results-grid/pages/search/audio/pages/search/index.js |
3.01 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-all-results-grid/pages/search/audio/pages/search/index.modern.js |
2.92 kB | 0 B |
./.nuxt/dist/client/components/v-audio-cell.js |
357 B | 0 B |
./.nuxt/dist/client/components/v-audio-cell.modern.js |
360 B | 0 B |
./.nuxt/dist/client/components/v-audio-details.js |
1.82 kB | 0 B |
./.nuxt/dist/client/components/v-audio-details.modern.js |
1.79 kB | 0 B |
./.nuxt/dist/client/components/v-audio-track-skeleton.js |
1.01 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js |
1.02 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-audio-track.js |
5.12 kB | +7 B (0%) |
./.nuxt/dist/client/components/v-audio-track.modern.js |
5.06 kB | +3 B (0%) |
./.nuxt/dist/client/components/v-back-to-search-results-link.js |
542 B | +5 B (+1%) |
./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js |
545 B | +3 B (+1%) |
./.nuxt/dist/client/components/v-bone.js |
684 B | -1 B (0%) |
./.nuxt/dist/client/components/v-bone.modern.js |
691 B | +1 B (0%) |
./.nuxt/dist/client/components/v-box-layout.js |
1.2 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-box-layout.modern.js |
1.2 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-content-link.js |
1.12 kB | +9 B (+1%) |
./.nuxt/dist/client/components/v-content-link.modern.js |
1.1 kB | +5 B (0%) |
./.nuxt/dist/client/components/v-content-page.js |
466 B | -1 B (0%) |
./.nuxt/dist/client/components/v-content-page.modern.js |
471 B | 0 B |
./.nuxt/dist/client/components/v-content-report-button.js |
782 B | +4 B (+1%) |
./.nuxt/dist/client/components/v-content-report-button.modern.js |
785 B | +1 B (0%) |
./.nuxt/dist/client/components/v-content-report-form.js |
3.75 kB | 0 B |
./.nuxt/dist/client/components/v-content-report-form.modern.js |
3.57 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-content-report-popover.modern.js |
4.24 kB | +6 B (0%) |
./.nuxt/dist/client/components/v-copy-button.js |
3.98 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-copy-button.modern.js |
3.99 kB | 0 B |
./.nuxt/dist/client/components/v-copy-license.js |
1 kB | 0 B |
./.nuxt/dist/client/components/v-copy-license.modern.js |
1 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.js |
9.5 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.modern.js |
9.48 kB | 0 B |
./.nuxt/dist/client/components/v-dmca-notice.js |
748 B | -1 B (0%) |
./.nuxt/dist/client/components/v-dmca-notice.modern.js |
753 B | 0 B |
./.nuxt/dist/client/components/v-error-image.js |
1.69 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-error-image.modern.js |
1.68 kB | +2 B (0%) |
./.nuxt/dist/client/components/v-error-section.js |
372 B | 0 B |
./.nuxt/dist/client/components/v-error-section.modern.js |
376 B | 0 B |
./.nuxt/dist/client/components/v-external-search-form.js |
3.12 kB | +7 B (0%) |
./.nuxt/dist/client/components/v-external-source-list.js |
2.58 kB | +7 B (0%) |
./.nuxt/dist/client/components/v-external-source-list.modern.js |
2.55 kB | +8 B (0%) |
./.nuxt/dist/client/components/v-full-layout.js |
1.49 kB | +4 B (0%) |
./.nuxt/dist/client/components/v-full-layout.modern.js |
1.49 kB | +6 B (0%) |
./.nuxt/dist/client/components/v-grid-skeleton.js |
1.6 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-grid-skeleton.modern.js |
1.61 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-image-cell-square.js |
1.01 kB | 0 B |
./.nuxt/dist/client/components/v-image-cell-square.modern.js |
1.02 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-image-cell.js |
1.43 kB | 0 B |
./.nuxt/dist/client/components/v-image-cell.modern.js |
1.42 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-image-details.js |
1.44 kB | 0 B |
./.nuxt/dist/client/components/v-image-details.modern.js |
1.43 kB | 0 B |
./.nuxt/dist/client/components/v-image-grid.js |
2.53 kB | 0 B |
./.nuxt/dist/client/components/v-image-grid.modern.js |
2.41 kB | -2 B (0%) |
./.nuxt/dist/client/components/v-license-tab-panel.js |
522 B | 0 B |
./.nuxt/dist/client/components/v-license-tab-panel.modern.js |
524 B | 0 B |
./.nuxt/dist/client/components/v-load-more.js |
788 B | 0 B |
./.nuxt/dist/client/components/v-load-more.modern.js |
683 B | 0 B |
./.nuxt/dist/client/components/v-media-license.js |
799 B | 0 B |
./.nuxt/dist/client/components/v-media-license.modern.js |
808 B | 0 B |
./.nuxt/dist/client/components/v-media-reuse.js |
1.63 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-media-reuse.modern.js |
1.62 kB | -2 B (0%) |
./.nuxt/dist/client/components/v-media-tag.js |
430 B | 0 B |
./.nuxt/dist/client/components/v-media-tag.modern.js |
434 B | 0 B |
./.nuxt/dist/client/components/v-no-results.js |
2.78 kB | +6 B (0%) |
./.nuxt/dist/client/components/v-no-results.modern.js |
2.75 kB | +9 B (0%) |
./.nuxt/dist/client/components/v-radio.js |
1.51 kB | -2 B (0%) |
./.nuxt/dist/client/components/v-radio.modern.js |
1.47 kB | 0 B |
./.nuxt/dist/client/components/v-related-audio.js |
1.23 kB | 0 B |
./.nuxt/dist/client/components/v-related-audio.modern.js |
1.23 kB | +3 B (0%) |
./.nuxt/dist/client/components/v-related-images.js |
3.09 kB | -2 B (0%) |
./.nuxt/dist/client/components/v-related-images.modern.js |
2.97 kB | -2 B (0%) |
./.nuxt/dist/client/components/v-report-desc-form.js |
966 B | 0 B |
./.nuxt/dist/client/components/v-report-desc-form.modern.js |
965 B | 0 B |
./.nuxt/dist/client/components/v-row-layout.js |
1.7 kB | -1 B (0%) |
./.nuxt/dist/client/components/v-row-layout.modern.js |
1.7 kB | 0 B |
./.nuxt/dist/client/components/v-scroll-button.js |
813 B | 0 B |
./.nuxt/dist/client/components/v-scroll-button.modern.js |
819 B | 0 B |
./.nuxt/dist/client/components/v-search-grid.js |
5.46 kB | +8 B (0%) |
./.nuxt/dist/client/components/v-search-results-title.js |
659 B | +1 B (0%) |
./.nuxt/dist/client/components/v-search-results-title.modern.js |
650 B | -1 B (0%) |
./.nuxt/dist/client/components/v-search-type-radio.js |
800 B | +7 B (+1%) |
./.nuxt/dist/client/components/v-search-type-radio.modern.js |
777 B | +6 B (+1%) |
./.nuxt/dist/client/components/v-server-timeout.js |
299 B | 0 B |
./.nuxt/dist/client/components/v-server-timeout.modern.js |
303 B | 0 B |
./.nuxt/dist/client/components/v-sketch-fab-viewer.js |
997 B | 0 B |
./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js |
894 B | 0 B |
./.nuxt/dist/client/components/v-skip-to-content-container.js |
888 B | 0 B |
./.nuxt/dist/client/components/v-skip-to-content-container.modern.js |
892 B | -1 B (0%) |
./.nuxt/dist/client/components/v-snackbar.js |
1.18 kB | +1 B (0%) |
./.nuxt/dist/client/components/v-snackbar.modern.js |
1.19 kB | +2 B (0%) |
./.nuxt/dist/client/components/v-warning-suppressor.js |
298 B | 0 B |
./.nuxt/dist/client/components/v-warning-suppressor.modern.js |
303 B | 0 B |
./.nuxt/dist/client/pages/about.js |
1.06 kB | -1 B (0%) |
./.nuxt/dist/client/pages/about.modern.js |
1.07 kB | 0 B |
./.nuxt/dist/client/pages/audio/_id.js |
4.89 kB | -3 B (0%) |
./.nuxt/dist/client/pages/audio/_id.modern.js |
4.73 kB | +5 B (0%) |
./.nuxt/dist/client/pages/external-sources.js |
1.45 kB | +5 B (0%) |
./.nuxt/dist/client/pages/external-sources.modern.js |
1.45 kB | 0 B |
./.nuxt/dist/client/pages/feedback.js |
1.24 kB | +2 B (0%) |
./.nuxt/dist/client/pages/feedback.modern.js |
1.24 kB | +1 B (0%) |
./.nuxt/dist/client/pages/image/_id.js |
5.29 kB | +7 B (0%) |
./.nuxt/dist/client/pages/index.js |
5.06 kB | +7 B (0%) |
./.nuxt/dist/client/pages/index.modern.js |
4.92 kB | +7 B (0%) |
./.nuxt/dist/client/pages/preferences.js |
1.21 kB | -9 B (-1%) |
./.nuxt/dist/client/pages/preferences.modern.js |
1.21 kB | +1 B (0%) |
./.nuxt/dist/client/pages/search-help.js |
1.55 kB | 0 B |
./.nuxt/dist/client/pages/search-help.modern.js |
1.55 kB | +1 B (0%) |
./.nuxt/dist/client/pages/search.js |
2.75 kB | +2 B (0%) |
./.nuxt/dist/client/pages/search.modern.js |
2.6 kB | 0 B |
./.nuxt/dist/client/pages/search/audio.js |
1.19 kB | +2 B (0%) |
./.nuxt/dist/client/pages/search/audio.modern.js |
1.2 kB | +1 B (0%) |
./.nuxt/dist/client/pages/search/image.js |
2.79 kB | +6 B (0%) |
./.nuxt/dist/client/pages/search/image.modern.js |
2.67 kB | -1 B (0%) |
./.nuxt/dist/client/pages/search/index.modern.js |
2.95 kB | +9 B (0%) |
./.nuxt/dist/client/pages/search/model-3d.js |
242 B | -1 B (0%) |
./.nuxt/dist/client/pages/search/model-3d.modern.js |
246 B | 0 B |
./.nuxt/dist/client/pages/search/search-page.types.js |
266 B | 0 B |
./.nuxt/dist/client/pages/search/search-page.types.modern.js |
271 B | 0 B |
./.nuxt/dist/client/pages/search/video.js |
240 B | 0 B |
./.nuxt/dist/client/pages/search/video.modern.js |
243 B | 0 B |
./.nuxt/dist/client/pages/sources.js |
1.45 kB | +2 B (0%) |
./.nuxt/dist/client/pages/sources.modern.js |
1.45 kB | +5 B (0%) |
./.nuxt/dist/client/vendors/app.js |
57.2 kB | +5 B (0%) |
./.nuxt/dist/client/vendors/app.modern.js |
56.5 kB | +1 B (0%) |
Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR:
@zackkrida This reminder is being automatically generated due to the urgency configuration.
Excluding weekend[^1] days, this PR was updated 2 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)[^2].
@obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.
[^1]: Specifically, Saturday and Sunday. [^2]: For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.
Closing this PR because we have decided that keeping the size prop is a better approach.