openverse-frontend icon indicating copy to clipboard operation
openverse-frontend copied to clipboard

Show all filetypes of audio in details page

Open krysal opened this issue 3 years ago â€ĸ 3 comments
trafficstars

Fixes

Fixes #878 by @AetherUnbound

Description

Shows the multiple file types of the audio track in the information section when available.

Testing Instructions

  1. Run the project pnpm dev
  2. Look for an audio track with multiple file types, which currently are only provided by Freesound, e.g. http://localhost:8443/audio/685531e7-fb32-4618-b9c1-472bdc3ff059
  3. See the "Format"

Checklist

  • [x] My pull request has a descriptive title (not a vague title like Update index.md).
  • [x] My pull request targets the default branch of the repository (main) or a parent feature branch.
  • [x] My commit messages follow best practices.
  • [x] My code follows the established code style of the repository.
  • [x] I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • [x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

krysal avatar Aug 30 '22 20:08 krysal

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/1763 Tailwind: https://wordpress.github.io/openverse-frontend/_preview/1763/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

github-actions[bot] avatar Aug 30 '22 20:08 github-actions[bot]

Size Change: -1.65 kB (0%)

Total Size: 767 kB

Filename Size Change
./.nuxt/dist/client/235.js 0 B -273 B (removed) 🏆
./.nuxt/dist/client/235.modern.js 0 B -277 B (removed) 🏆
./.nuxt/dist/client/236.js 0 B -1.85 kB (removed) 🏆
./.nuxt/dist/client/app.js 109 kB -1.09 kB (-1%)
./.nuxt/dist/client/app.modern.js 102 kB -1.02 kB (-1%)
./.nuxt/dist/client/components/v-audio-details.js 1.81 kB +158 B (+10%) âš ī¸
./.nuxt/dist/client/components/v-audio-details.modern.js 1.79 kB +144 B (+9%) 🔍
./.nuxt/dist/client/pages/audio/_id.js 6.56 kB +142 B (+2%)
./.nuxt/dist/client/pages/audio/_id.modern.js 6.39 kB +127 B (+2%)
./.nuxt/dist/client/runtime.js 2.65 kB -56 B (-2%)
./.nuxt/dist/client/runtime.modern.js 2.65 kB -56 B (-2%)
./.nuxt/dist/client/224.js 272 B +272 B (new file) 🆕
./.nuxt/dist/client/224.modern.js 277 B +277 B (new file) 🆕
./.nuxt/dist/client/225.js 1.85 kB +1.85 kB (new file) 🆕
â„šī¸ View Unchanged
Filename Size Change
./.nuxt/dist/client/commons/app.js 87.8 kB -1 B (0%)
./.nuxt/dist/client/commons/app.modern.js 76.7 kB +2 B (0%)
./.nuxt/dist/client/components/loading-icon.js 746 B 0 B
./.nuxt/dist/client/components/loading-icon.modern.js 751 B 0 B
./.nuxt/dist/client/components/table-sort-icon.js 508 B 0 B
./.nuxt/dist/client/components/table-sort-icon.modern.js 512 B 0 B
./.nuxt/dist/client/components/v-all-results-grid.js 4.13 kB 0 B
./.nuxt/dist/client/components/v-all-results-grid.modern.js 4.01 kB -2 B (0%)
./.nuxt/dist/client/components/v-audio-cell.js 344 B 0 B
./.nuxt/dist/client/components/v-audio-cell.modern.js 349 B 0 B
./.nuxt/dist/client/components/v-audio-track-skeleton.js 1.01 kB 0 B
./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.02 kB 0 B
./.nuxt/dist/client/components/v-audio-track.js 4.55 kB 0 B
./.nuxt/dist/client/components/v-audio-track.modern.js 4.51 kB -1 B (0%)
./.nuxt/dist/client/components/v-back-to-search-results-link.js 570 B 0 B
./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 575 B 0 B
./.nuxt/dist/client/components/v-bone.js 685 B 0 B
./.nuxt/dist/client/components/v-bone.modern.js 690 B 0 B
./.nuxt/dist/client/components/v-box-layout.js 1.19 kB 0 B
./.nuxt/dist/client/components/v-box-layout.modern.js 1.19 kB 0 B
./.nuxt/dist/client/components/v-content-link.js 1.06 kB 0 B
./.nuxt/dist/client/components/v-content-link.modern.js 1.04 kB 0 B
./.nuxt/dist/client/components/v-content-page.js 467 B 0 B
./.nuxt/dist/client/components/v-content-page.modern.js 471 B 0 B
./.nuxt/dist/client/components/v-content-report-button.js 763 B 0 B
./.nuxt/dist/client/components/v-content-report-button.modern.js 773 B 0 B
./.nuxt/dist/client/components/v-content-report-form.js 3.78 kB 0 B
./.nuxt/dist/client/components/v-content-report-form.modern.js 3.59 kB 0 B
./.nuxt/dist/client/components/v-content-report-popover.js 4.45 kB 0 B
./.nuxt/dist/client/components/v-content-report-popover.modern.js 4.26 kB 0 B
./.nuxt/dist/client/components/v-copy-button.js 3.97 kB 0 B
./.nuxt/dist/client/components/v-copy-button.modern.js 3.98 kB 0 B
./.nuxt/dist/client/components/v-copy-license.js 2.94 kB 0 B
./.nuxt/dist/client/components/v-copy-license.modern.js 2.91 kB 0 B
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.js 9.4 kB 0 B
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.modern.js 9.38 kB 0 B
./.nuxt/dist/client/components/v-dmca-notice.js 743 B 0 B
./.nuxt/dist/client/components/v-dmca-notice.modern.js 753 B 0 B
./.nuxt/dist/client/components/v-error-image.js 1.69 kB 0 B
./.nuxt/dist/client/components/v-error-image.modern.js 1.68 kB 0 B
./.nuxt/dist/client/components/v-error-section.js 372 B 0 B
./.nuxt/dist/client/components/v-error-section.modern.js 375 B 0 B
./.nuxt/dist/client/components/v-full-layout.js 1.55 kB 0 B
./.nuxt/dist/client/components/v-full-layout.modern.js 1.55 kB 0 B
./.nuxt/dist/client/components/v-grid-skeleton.js 1.61 kB 0 B
./.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.62 kB 0 B
./.nuxt/dist/client/components/v-image-cell-square.js 1.01 kB 0 B
./.nuxt/dist/client/components/v-image-cell-square.modern.js 1.02 kB 0 B
./.nuxt/dist/client/components/v-image-cell.js 1.43 kB 0 B
./.nuxt/dist/client/components/v-image-cell.modern.js 1.42 kB 0 B
./.nuxt/dist/client/components/v-image-details.js 1.44 kB 0 B
./.nuxt/dist/client/components/v-image-details.modern.js 1.43 kB 0 B
./.nuxt/dist/client/components/v-image-grid.js 2.57 kB 0 B
./.nuxt/dist/client/components/v-image-grid.modern.js 2.46 kB 0 B
./.nuxt/dist/client/components/v-license-tab-panel.js 923 B 0 B
./.nuxt/dist/client/components/v-license-tab-panel.modern.js 918 B 0 B
./.nuxt/dist/client/components/v-load-more.js 815 B 0 B
./.nuxt/dist/client/components/v-load-more.modern.js 714 B -1 B (0%)
./.nuxt/dist/client/components/v-media-license.js 801 B 0 B
./.nuxt/dist/client/components/v-media-license.modern.js 809 B 0 B
./.nuxt/dist/client/components/v-media-reuse.js 1.03 kB 0 B
./.nuxt/dist/client/components/v-media-reuse.modern.js 1.03 kB 0 B
./.nuxt/dist/client/components/v-media-reuse/pages/image/_id.js 2.94 kB 0 B
./.nuxt/dist/client/components/v-media-reuse/pages/image/_id.modern.js 2.91 kB 0 B
./.nuxt/dist/client/components/v-media-tag.js 429 B 0 B
./.nuxt/dist/client/components/v-media-tag.modern.js 433 B 0 B
./.nuxt/dist/client/components/v-meta-search-form.js 2.7 kB 0 B
./.nuxt/dist/client/components/v-meta-search-form.modern.js 2.66 kB 0 B
./.nuxt/dist/client/components/v-meta-source-list.js 2.06 kB 0 B
./.nuxt/dist/client/components/v-meta-source-list.modern.js 2.02 kB 0 B
./.nuxt/dist/client/components/v-modal.js 875 B 0 B
./.nuxt/dist/client/components/v-modal.modern.js 877 B +1 B (0%)
./.nuxt/dist/client/components/v-no-results.js 2.27 kB 0 B
./.nuxt/dist/client/components/v-no-results.modern.js 2.23 kB 0 B
./.nuxt/dist/client/components/v-radio.js 1.51 kB 0 B
./.nuxt/dist/client/components/v-radio.modern.js 1.47 kB 0 B
./.nuxt/dist/client/components/v-related-audio.js 1.23 kB -1 B (0%)
./.nuxt/dist/client/components/v-related-audio.modern.js 1.24 kB -1 B (0%)
./.nuxt/dist/client/components/v-related-images.js 3.14 kB +1 B (0%)
./.nuxt/dist/client/components/v-related-images.modern.js 3.02 kB 0 B
./.nuxt/dist/client/components/v-report-desc-form.js 965 B 0 B
./.nuxt/dist/client/components/v-report-desc-form.modern.js 964 B 0 B
./.nuxt/dist/client/components/v-row-layout.js 1.72 kB 0 B
./.nuxt/dist/client/components/v-row-layout.modern.js 1.73 kB 0 B
./.nuxt/dist/client/components/v-scroll-button.js 804 B 0 B
./.nuxt/dist/client/components/v-scroll-button.modern.js 809 B 0 B
./.nuxt/dist/client/components/v-search-grid.js 5.06 kB 0 B
./.nuxt/dist/client/components/v-search-grid.modern.js 4.99 kB 0 B
./.nuxt/dist/client/components/v-search-results-title.js 673 B 0 B
./.nuxt/dist/client/components/v-search-results-title.modern.js 666 B 0 B
./.nuxt/dist/client/components/v-search-type-radio.js 831 B 0 B
./.nuxt/dist/client/components/v-search-type-radio.modern.js 820 B 0 B
./.nuxt/dist/client/components/v-server-timeout.js 298 B 0 B
./.nuxt/dist/client/components/v-server-timeout.modern.js 303 B 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.js 991 B 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 892 B 0 B
./.nuxt/dist/client/components/v-skip-to-content-container.js 888 B 0 B
./.nuxt/dist/client/components/v-skip-to-content-container.modern.js 891 B 0 B
./.nuxt/dist/client/components/v-snackbar.js 977 B 0 B
./.nuxt/dist/client/components/v-snackbar.modern.js 983 B 0 B
./.nuxt/dist/client/components/v-sources-table.js 14.3 kB 0 B
./.nuxt/dist/client/components/v-sources-table.modern.js 14.3 kB +1 B (0%)
./.nuxt/dist/client/components/v-tab-panel.js 689 B 0 B
./.nuxt/dist/client/components/v-tab-panel.modern.js 683 B 0 B
./.nuxt/dist/client/components/v-tab.js 1.73 kB 0 B
./.nuxt/dist/client/components/v-tab.modern.js 1.71 kB 0 B
./.nuxt/dist/client/components/v-tabs.js 779 B 0 B
./.nuxt/dist/client/components/v-tabs.modern.js 766 B 0 B
./.nuxt/dist/client/components/v-warning-suppressor.js 298 B 0 B
./.nuxt/dist/client/components/v-warning-suppressor.modern.js 302 B 0 B
./.nuxt/dist/client/pages/about.js 1.05 kB -1 B (0%)
./.nuxt/dist/client/pages/about.modern.js 1.06 kB -2 B (0%)
./.nuxt/dist/client/pages/feedback.js 3.23 kB +1 B (0%)
./.nuxt/dist/client/pages/feedback.modern.js 3.2 kB +1 B (0%)
./.nuxt/dist/client/pages/image/_id.js 7.05 kB +1 B (0%)
./.nuxt/dist/client/pages/image/_id.modern.js 6.83 kB +1 B (0%)
./.nuxt/dist/client/pages/index.js 5.09 kB +1 B (0%)
./.nuxt/dist/client/pages/index.modern.js 4.97 kB -2 B (0%)
./.nuxt/dist/client/pages/meta-search.js 1.67 kB +3 B (0%)
./.nuxt/dist/client/pages/meta-search.modern.js 1.68 kB +3 B (0%)
./.nuxt/dist/client/pages/preferences.js 1.28 kB 0 B
./.nuxt/dist/client/pages/preferences.modern.js 1.27 kB 0 B
./.nuxt/dist/client/pages/search-help.js 1.54 kB -1 B (0%)
./.nuxt/dist/client/pages/search-help.modern.js 1.54 kB -2 B (0%)
./.nuxt/dist/client/pages/search.js 2.72 kB 0 B
./.nuxt/dist/client/pages/search.modern.js 2.56 kB -2 B (0%)
./.nuxt/dist/client/pages/search/audio.js 2.86 kB 0 B
./.nuxt/dist/client/pages/search/audio.modern.js 2.75 kB 0 B
./.nuxt/dist/client/pages/search/image.js 2.96 kB 0 B
./.nuxt/dist/client/pages/search/image.modern.js 2.83 kB +1 B (0%)
./.nuxt/dist/client/pages/search/index.js 815 B 0 B
./.nuxt/dist/client/pages/search/index.modern.js 731 B -2 B (0%)
./.nuxt/dist/client/pages/search/model-3d.js 242 B 0 B
./.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.js 266 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.modern.js 271 B 0 B
./.nuxt/dist/client/pages/search/video.js 239 B 0 B
./.nuxt/dist/client/pages/search/video.modern.js 243 B -1 B (0%)
./.nuxt/dist/client/pages/sources.js 1.44 kB 0 B
./.nuxt/dist/client/pages/sources.modern.js 1.45 kB 0 B
./.nuxt/dist/client/vendors/app.js 47.8 kB +2 B (0%)
./.nuxt/dist/client/vendors/app.modern.js 47.1 kB +4 B (0%)

compressed-size-action

github-actions[bot] avatar Aug 30 '22 20:08 github-actions[bot]

Just noting that the new code for deduplication looks good 👍

zackkrida avatar Aug 31 '22 17:08 zackkrida