openverse-frontend icon indicating copy to clipboard operation
openverse-frontend copied to clipboard

Update Playwright to version ^1.25.0

Open obulat opened this issue 3 years ago • 2 comments

Problem

#1646 updated Playwright version to 1.24. However, the update to the most recent version, 1.25, was impossible due to some problems in rendering Arabic fonts.

Description

We need to investigate what changed in Playwright version 1.25 that caused the RTL rendering problems. Here is an example snapshot of the wrong Arabic version. Notice the NUL signs:

image

Additional context

This could be to some regression in Chromium that is bundled with Playwright Docker image.

Implementation

  • [ ] 🙋 I would be interested in implementing this feature.

obulat avatar Aug 29 '22 19:08 obulat

Interesting, this is using our custom webfonts so I wouldn't expect a character rendering issue to be associated with a browser release like this. I wonder if we can:

  • Identify the character that isn't rendering
  • Check if it works locally/in a browser
  • Identify why it would no longer work in Playwright

zackkrida avatar Aug 29 '22 20:08 zackkrida

The Arabic letters in the 1.25 snapshots seemed to be more squished into each other, for what it's worth. The letters were the same, mostly.

obulat avatar Aug 29 '22 20:08 obulat