openverse-frontend icon indicating copy to clipboard operation
openverse-frontend copied to clipboard

Published 20 hours ago • verified publisher icon WordPress

Handling play errors

Open ramadanomar opened this issue 3 years ago • 3 comments

Fixes

#1600 and #1605

Description

Thanks to @krysal and @sarayourfriend for all the tips and suggestions on the previous pr (#1713). We can manage the errors in a cleaner way. For local (settings) related errors, can we use the VSnackbar component to alert the user?

Draft

This pr is still wip as i have to write the test cases and figure how to make VSnackbar show

ramadanomar avatar Aug 24 '22 12:08 ramadanomar

Marking this as blocked until https://github.com/WordPress/openverse/issues/513 is sorted.

zackkrida avatar Aug 27 '22 00:08 zackkrida

I think we can finish this before the design issue is done with the already available waveform's message. I'll review this between today and tomorrow with that goal.

krysal avatar Aug 29 '22 14:08 krysal

That sounds good, @krysal, we can make the snackbar upgrade in a future follow up PR.

zackkrida avatar Aug 29 '22 16:08 zackkrida

I added that great test. Thank you a lot, @obulat 😄 This is ready for another review! CC @dhruvkb @zackkrida

krysal avatar Sep 07 '22 20:09 krysal

I'm going to merge this PR as @ramadanomar is away.

obulat avatar Sep 08 '22 06:09 obulat