openverse-frontend icon indicating copy to clipboard operation
openverse-frontend copied to clipboard

Showing the audio results link on results page when there are no results

Open fcoveram opened this issue 3 years ago • 2 comments

Description

When you search something that brings no audio results, the results page still shows the "see all audio" link. Like in this example.

Reproduction

  1. Search for "vanagon"
  2. Notice has the "see all audio" link says "no results".
  3. Click on it.
  4. See how the page shows no results.

Screenshots

CleanShot 2022-08-18 at 10 13 48@2x

Resolution

  • [ ] 🙋 I would be interested in resolving this bug.

fcoveram avatar Aug 18 '22 14:08 fcoveram

@panchovm what is the ideal UX in this scenario? Would disabling or hiding the "See all audio" button be a good solution?

dhruvkb avatar Aug 26 '22 09:08 dhruvkb

I was thinking it should go directly to the images search because that would enable the image filters but showing the "See all audio" button disabled sounds like a good option too, relatively easy to implement and will let the user know that there are no audio results for their search.

krysal avatar Aug 26 '22 13:08 krysal

+1 to disabling it. It keeps visible that the content type exists so visitors not clicking the switcher will notice we support audio content. I will add needs design as we need to add the disabled state of the component in the Design Library.

Thanks for the suggestion @dhruvkb

fcoveram avatar Sep 01 '22 16:09 fcoveram