openverse-frontend icon indicating copy to clipboard operation
openverse-frontend copied to clipboard

Switch to `ENTRYPOINT` instead of `CMD` in our Dockerfile

Open zackkrida opened this issue 3 years ago • 1 comments

Description

We would like to switch to using ENTRYPOINT instead of CMD in our Dockerfile because entrypoint accepts arguments without also requiring you to replace the entire command. This article explains the difference between the two well and makes recommendations:

if we pass non-option arguments to docker run, they will override the value of CMD.

If your image is built to do only one thing — for example, run a web server — use ENTRYPOINT to specify the path to the server binary and any mandatory arguments. A textbook example of this is the nginx image, whose sole purpose is to run the nginx web server. This lends itself to a pleasant and natural command line invocation: docker run nginx. Then you can append program arguments naturally on the command line, such as docker run nginx -c /test.conf – just like you would if you were running nginx without Docker.

Resolution

  • [x] 🙋 I would be interested in resolving this bug.

zackkrida avatar Aug 16 '22 19:08 zackkrida

Lowering the priority on this as it would be nice to have and is quite simple but is potentially no longer relevant to another problem I was trying to address with this issue.

zackkrida avatar Aug 16 '22 23:08 zackkrida